mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
312f42b6e4
When doing streaming compression with zlib, zlib appears to emit chunks with data after ~20-30kb on average is available. In other words, most calls to compress() return an empty string. On the mozilla-unified repo, only 48,433 of 921,167 (5.26%) of calls to compress() returned data. In other words, we were sending hundreds of thousands of empty chunks via a generator where they touched who knows how many frames (my guess is millions). Filtering out the empty chunks from the generator cuts down on overhead. In addition, we were previously feeding 8kb chunks into zlib compression. Since this function tends to emit *compressed* data after 20-30kb is available, it would take several calls before data was produced. We increase the amount of data fed in at a time to 32kb. This reduces the number of calls to compress() from 921,167 to 115,146. It also reduces the number of output chunks from 48,433 to 31,377. This does increase the average output chunk size by a little. But I don't think this will matter in most scenarios. The combination of these 2 changes appears to shave ~6s CPU time or ~3% from a server serving the mozilla-unified repo. |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| common.py | ||
| hgweb_mod.py | ||
| hgwebdir_mod.py | ||
| protocol.py | ||
| request.py | ||
| server.py | ||
| webcommands.py | ||
| webutil.py | ||
| wsgicgi.py | ||