mirror of
https://github.com/facebook/sapling.git
synced 2024-10-06 06:47:41 +03:00
19ce8cdcd8
Summary: Drop the `stdout` and `stderr` arguments, so that this method always return a string. Change callers that were previously calling this method with `stderr=None` to use the `run_hg()` method instead of `hg()`. `run_hg()` returns a `subprocess.CompletedProcess` object. This change simplifies the python type checking, and fixes several existing type checking errors in the code. Even though most call sites could be guaranteed that this function would return a `str`, the type checker wasn't smart enough to tell that the return type would be fixed based on the argument values, and so it assumed the result always needed to be checked for `None`. This also updates the `GitRepository.git()` method in a similar fashion. However, that was a simpler change since it already returned a `str` in all cases. Reviewed By: strager Differential Revision: D13078095 fbshipit-source-id: a8def2a33edc865ac40279bbcb3ada4dade68374 |
||
---|---|---|
.. | ||
lib | ||
absorb_test.py | ||
add_test.py | ||
branch_test.py | ||
commit_test.py | ||
copy_test.py | ||
debug_clear_local_caches_test.py | ||
debug_hg_dirstate_test.py | ||
debug_hg_get_dirstate_tuple_test.py | ||
diff_test.py | ||
files_test.py | ||
fold_test.py | ||
graft_test.py | ||
grep_test.py | ||
histedit_test.py | ||
journal_test.py | ||
merge_test.py | ||
move_test.py | ||
negative_caching_test.py | ||
non_eden_operation_test.py | ||
post_clone_test.py | ||
pull_test.py | ||
README.md | ||
rebase_test.py | ||
revert_test.py | ||
rm_test.py | ||
rollback_test.py | ||
sparse_test.py | ||
split_test.py | ||
status_deadlock_test.py | ||
status_test.py | ||
storage_engine_test.py | ||
symlink_test.py | ||
undo_test.py | ||
update_flatmanifest_test.py | ||
update_test.py |
Integration tests in this directory are specific to the Eden extension for Mercurial.
Most tests will want to subclass HgExtensionTestBase
.