sapling/eden/integration/hg
Adam Simpkins 19ce8cdcd8 update HgRepository.hg() to always return a string
Summary:
Drop the `stdout` and `stderr` arguments, so that this method always return a
string.  Change callers that were previously calling this method with
`stderr=None` to use the `run_hg()` method instead of `hg()`.  `run_hg()`
returns a `subprocess.CompletedProcess` object.

This change simplifies the python type checking, and fixes several existing
type checking errors in the code.  Even though most call sites could be
guaranteed that this function would return a `str`, the type checker wasn't
smart enough to tell that the return type would be fixed based on the argument
values, and so it assumed the result always needed to be checked for `None`.

This also updates the `GitRepository.git()` method in a similar fashion.
However, that was a simpler change since it already returned a `str` in all
cases.

Reviewed By: strager

Differential Revision: D13078095

fbshipit-source-id: a8def2a33edc865ac40279bbcb3ada4dade68374
2018-11-16 19:47:48 -08:00
..
lib update HgRepository.hg() to always return a string 2018-11-16 19:47:48 -08:00
absorb_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
add_test.py fix dirstate.walk()'s handling of ignored symlinks 2018-08-23 15:07:02 -07:00
branch_test.py tweakdefaults: port allowbranches to core 2018-10-22 20:27:25 -07:00
commit_test.py update HgRepository.hg() to always return a string 2018-11-16 19:47:48 -08:00
copy_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
debug_clear_local_caches_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
debug_hg_dirstate_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
debug_hg_get_dirstate_tuple_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
diff_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
files_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
fold_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
graft_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
grep_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
histedit_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
journal_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
merge_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
move_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
negative_caching_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
non_eden_operation_test.py re-enable test_hg_clone_non_eden_repo_within_eden_repo for treemanifest 2018-11-06 18:08:09 -08:00
post_clone_test.py ensure .hg has read and search permissions for group/other 2018-06-11 22:33:11 -07:00
pull_test.py update HgRepository.hg() to always return a string 2018-11-16 19:47:48 -08:00
README.md move integration tests to eden/integration 2017-01-31 14:41:14 -08:00
rebase_test.py update HgRepository.hg() to always return a string 2018-11-16 19:47:48 -08:00
revert_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
rm_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
rollback_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
sparse_test.py sparse: add sparse show 2018-10-22 20:27:26 -07:00
split_test.py Upgrade to 18.5b1 2018-05-30 01:11:47 -07:00
status_deadlock_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
status_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
storage_engine_test.py restructure storage_engine_test to make the type checkers happy 2018-11-16 19:47:47 -08:00
symlink_test.py tests: change HgRepository.status() to return a dictionary 2018-10-23 13:39:35 -07:00
undo_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
update_flatmanifest_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00
update_test.py add member type annotations to make pyre happy 2018-11-14 13:03:09 -08:00

Integration tests in this directory are specific to the Eden extension for Mercurial.

Most tests will want to subclass HgExtensionTestBase.