mirror of
https://github.com/facebook/sapling.git
synced 2024-09-11 18:47:10 +03:00
395ef6998a
Summary: Animation can hurt productivity. Popular applications that draw context menu on their own, like VS Code (Windows), FireFox, JetBrains Fleet, do not seem to use animations for context menus. Chrome (and Edge) only recently starts showing menu fading animation but I can see that fading animation hurting productivity. I personally find fading in/out, zooming in/out annoying if the duration is long too. The sliding animation can be useful to indicate what items are moving to what destinations (so we added it to the edit stack UI). Animations also varies on OS - the flashing behavior is a macOS behavior. On Windows the OS behavior is to fade out the selected item. There are other complexities on the fade out in theory - need to disable `:hover` and "pin" selection, and need `pointer-events: none`. For now, let's just remove the macOS-like context menu animations. This avoids issues like hovering different items during the fade-out, CSS animation out-of-sync with setTimeout, etc. Reviewed By: evangrayk Differential Revision: D52107206 fbshipit-source-id: 6d0eb1f198d5ae3aeb67bde8659f4a70c66941c2 |
||
|---|---|---|
| .. | ||
| __mocks__ | ||
| __tests__ | ||
| github | ||
| patch | ||
| SplitDiffView | ||
| textmate-lib | ||
| third-party/github | ||
| types | ||
| CancellationToken.ts | ||
| Comparison.ts | ||
| compat.ts | ||
| ContextMenu.css | ||
| ContextMenu.tsx | ||
| createTokenizedIntralineDiff.test.tsx | ||
| createTokenizedIntralineDiff.tsx | ||
| debounce.ts | ||
| diff.ts | ||
| Drawers.css | ||
| Drawers.tsx | ||
| EnsureAssignedTogether.ts | ||
| fs.ts | ||
| hooks.tsx | ||
| Icon.css | ||
| Icon.tsx | ||
| immutableExt.ts | ||
| jest.config.ts | ||
| KeyboardShortcuts.tsx | ||
| lazyInit.ts | ||
| LRU.ts | ||
| minimalDisambiguousPaths.ts | ||
| OperatingSystem.ts | ||
| package.json | ||
| pathUtils.ts | ||
| RateLimiter.ts | ||
| rejectAfterTimeout.ts | ||
| testUtils.ts | ||
| tsconfig.json | ||
| TypedEventEmitter.ts | ||
| typeUtils.ts | ||
| utils.ts | ||
| zoom.tsx | ||