sapling/eden
Xavier Deguillard 1b2abb2006 prjfs: move PrjfsChannel::start onto PrjfsChannel::initialize
Summary:
In the case where PrjfsChannel::start failed to initialized, EdenFS would crash
due to the stopPromise_ not being fulfilled. That promise is being set in the
PrjfsChannel::stop method, but unfortunately, when start throws, the caller
wouldn't catch the exception.

To fix this, we can simply move all the code in the initialize method, which if
it throws, the caller already properly tears down the mount thus solving the
crash mentioned above.

Reviewed By: genevievehelsel

Differential Revision: D46210460

fbshipit-source-id: 1524e8e0fc74ce3119b1b6dcd35b5419efcebdf3
2023-06-06 12:36:24 -07:00
..
fs prjfs: move PrjfsChannel::start onto PrjfsChannel::initialize 2023-06-06 12:36:24 -07:00
integration Add getBlake3 method to eden service 2023-06-05 23:41:35 -07:00
locale
mononoke add make unlink command support more blobstores 2023-06-06 08:32:15 -07:00
scm smartset: optimize 'generatorset & set' by applying a cutoff 2023-06-06 11:13:25 -07:00
test_support asyncio loop vars for 3.10 2023-05-01 10:56:58 -07:00
test-data test-data: remove snapshot 20190313 2022-02-04 13:50:48 -08:00
testlib auth: don't load certs if auth proxy enabled 2023-05-09 09:53:48 -07:00
.clang-tidy clang-tidy: disable facebook-hte-ContextDependentStaticInit 2022-11-04 15:33:50 -07:00
.gitignore
.mononoke_test_file test push 2022-01-06 05:57:35 -08:00
Eden.project.toml