mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 17:27:53 +03:00
584656dff3
Summary: Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`. Then run `arc lint` again so some other autofixers like spellchecker etc. looked at the code base. Manually accept the changes whenever they make sense, or use a workaround (ex. changing "dict()" to "dict constructor") where autofix is false positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less interesting to fix (hgsubversion tests), or cannot be fixed without breaking OSS build (FBPYTHON4). Conflicted linters (test-check-module-imports.t, part of test-check-code.t, test-check-pyflakes.t) are removed or disabled. Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed. An issue of the auto-formatter is lines are no longer guarnateed to be <= 80 chars. But that seems less important comparing with the benefit auto-formatter provides. As we're here, also remove test-check-py3-compat.t, as it is currently broken if `PYTHON3=/bin/python3` is set. Reviewed By: wez, phillco, simpkins, pkaush, singhsrb Differential Revision: D8173629 fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
39 lines
892 B
Python
Executable File
39 lines
892 B
Python
Executable File
#!/usr/bin/env python
|
|
|
|
# Filter output by pyflakes to control which warnings we check
|
|
|
|
from __future__ import absolute_import, print_function
|
|
|
|
import re
|
|
import sys
|
|
|
|
|
|
lines = []
|
|
for line in sys.stdin:
|
|
# We blacklist tests that are too noisy for us
|
|
pats = [
|
|
r"undefined name 'WindowsError'",
|
|
r"redefinition of unused '[^']+' from line",
|
|
# for cffi, allow re-exports from pure.*
|
|
r"cffi/[^:]*:.*\bimport \*' used",
|
|
r"cffi/[^:]*:.*\*' imported but unused",
|
|
]
|
|
|
|
keep = True
|
|
for pat in pats:
|
|
if re.search(pat, line):
|
|
keep = False
|
|
break # pattern matches
|
|
if keep:
|
|
fn = line.split(":", 1)[0]
|
|
f = open(fn)
|
|
data = f.read()
|
|
f.close()
|
|
if "no-" "check-code" in data:
|
|
continue
|
|
lines.append(line)
|
|
|
|
for line in lines:
|
|
sys.stdout.write(line)
|
|
print()
|