mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 17:27:53 +03:00
9dc21f8d0b
Summary: D13853115 adds `edenscm/` to `sys.path` and code still uses `import mercurial`. That has nasty problems if both `import mercurial` and `import edenscm.mercurial` are used, because Python would think `mercurial.foo` and `edenscm.mercurial.foo` are different modules so code like `try: ... except mercurial.error.Foo: ...`, or `isinstance(x, mercurial.foo.Bar)` would fail to handle the `edenscm.mercurial` version. There are also some module-level states (ex. `extensions._extensions`) that would cause trouble if they have multiple versions in a single process. Change imports to use the `edenscm` so ideally the `mercurial` is no longer imported at all. Add checks in extensions.py to catch unexpected extensions importing modules from the old (wrong) locations when running tests. Reviewed By: phillco Differential Revision: D13868981 fbshipit-source-id: f4e2513766957fd81d85407994f7521a08e4de48
53 lines
1.5 KiB
Raku
53 lines
1.5 KiB
Raku
Test namespace registration using registrar
|
|
|
|
$ shorttraceback
|
|
|
|
$ newrepo
|
|
$ newext << EOF
|
|
> from edenscm.mercurial import registrar, namespaces
|
|
> namespacepredicate = registrar.namespacepredicate()
|
|
> @namespacepredicate("a", priority=60)
|
|
> def a(_repo):
|
|
> return namespaces.namespace()
|
|
> @namespacepredicate("b", priority=70)
|
|
> def b(_repo):
|
|
> return None
|
|
> @namespacepredicate("c", priority=50)
|
|
> def c(_repo):
|
|
> return namespaces.namespace()
|
|
> EOF
|
|
|
|
$ hg debugshell -c "print(list(repo.names))"
|
|
['bookmarks', 'tags', 'branches', 'c', 'a']
|
|
|
|
$ newext << EOF
|
|
> from edenscm.mercurial import registrar, namespaces
|
|
> namespacepredicate = registrar.namespacepredicate()
|
|
> @namespacepredicate("z", priority=99)
|
|
> def z(_repo):
|
|
> return namespaces.namespace()
|
|
> @namespacepredicate("d", priority=15)
|
|
> def d(_repo):
|
|
> return namespaces.namespace()
|
|
> EOF
|
|
$ hg debugshell -c "print(list(repo.names))"
|
|
['bookmarks', 'd', 'tags', 'branches', 'c', 'a', 'z']
|
|
|
|
|
|
Test that not specifying the priority will result in failure to load the
|
|
extension.
|
|
|
|
$ newext << EOF
|
|
> from edenscm.mercurial import registrar, namespaces
|
|
> namespacepredicate = registrar.namespacepredicate()
|
|
> @namespacepredicate("x", priority=None)
|
|
> def z(_repo):
|
|
> return namespaces.namespace()
|
|
> EOF
|
|
|
|
|
|
- Run any command to test that the extension loading failed.
|
|
|
|
$ hg status
|
|
* failed to import extension *: namespace priority must be specified (glob)
|