David Tolnay 713973975d Replace *fbinit::FACEBOOK with #[fbinit::main] ... Summary: This diff moves initFacebook calls that used to happen just before FFI calls to instead happen at the beginning of main. The basic assumption of initFacebook is that it happens at the beginning of main before there are additional threads. It must be allowed to modify process-global state like env vars or gflags without the possibility of a data race from other code concurrently reading those things. As such, the previous approach of calling initFacebook through `*fbinit::FACEBOOK` near FFI calls was prone to race conditions. The new approach is based on attribute macros added in D17245802. --- The primary remaining situations that still require `*fbinit::FACEBOOK` are when we don't directly control the function arguments surrounding the call to C++, such as in lazy_static: lazy_static! { static ref S: Ty = { let _ = *fbinit::FACEBOOK; /* call C++ */ }; } and quickcheck: quickcheck! { fn f(/* args that impl Arbitrary */) { let _ = *fbinit::FACEBOOK; /* call C++ */ } } I will revisit these in a separate diff. They are a small fraction of total uses of fbinit. Reviewed By: Imxset21 Differential Revision: D17328504 fbshipit-source-id: f80edb763e7f42b3216552dd32f1ea0e6cc8fd12		2019-09-13 20:17:29 -07:00
..
config.rs	added new admin subcommand to verify manifest generation logic	2019-07-12 07:31:02 -07:00
main.rs	Replace *fbinit::FACEBOOK with #[fbinit::main]	2019-09-13 20:17:29 -07:00