mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 08:18:15 +03:00
1ec3027f1e
Summary: test_reading_committed_file_bumps_read_counter is flaky with optimized builds of edenfs. I think it's flaky because FuseChannel bumps counters *after* responding to the kernel, so the test can call get_counters before the counters are bumped. Fix the flakiness by making the test wait a while for the counters to change. Reviewed By: chadaustin Differential Revision: D15550972 fbshipit-source-id: 891e5d0a9748b43eb0ef1089ef6bc0a547c47d4d
126 lines
4.2 KiB
Python
126 lines
4.2 KiB
Python
#!/usr/bin/env python3
|
|
#
|
|
# Copyright (c) 2016-present, Facebook, Inc.
|
|
# All rights reserved.
|
|
#
|
|
# This source code is licensed under the BSD-style license found in the
|
|
# LICENSE file in the root directory of this source tree. An additional grant
|
|
# of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
import logging
|
|
import time
|
|
import typing
|
|
from pathlib import Path
|
|
|
|
from .lib import testcase
|
|
from .lib.hgrepo import HgRepository
|
|
|
|
|
|
Counters = typing.Mapping[str, float]
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class FUSEStatsTest(testcase.EdenRepoTest):
|
|
def test_reading_committed_file_bumps_read_counter(self) -> None:
|
|
counters_before = self.get_counters()
|
|
path = Path(self.mount) / "file"
|
|
path.read_bytes()
|
|
|
|
self.poll_until_counter_condition(
|
|
lambda counters_after: self.assertGreater(
|
|
counters_after.get("fuse.read_us.count", 0),
|
|
counters_before.get("fuse.read_us.count", 0),
|
|
f"Reading {path} should increment fuse.read_us.count",
|
|
)
|
|
)
|
|
|
|
def test_writing_untracked_file_bumps_write_counter(self) -> None:
|
|
counters_before = self.get_counters()
|
|
path = Path(self.mount) / "new_file"
|
|
path.write_bytes(b"hello")
|
|
|
|
self.poll_until_counter_condition(
|
|
lambda counters_after: self.assertGreater(
|
|
counters_after.get("fuse.write_us.count", 0),
|
|
counters_before.get("fuse.write_us.count", 0),
|
|
f"Writing to {path} should increment fuse.write_us.count",
|
|
)
|
|
)
|
|
|
|
def create_repo(self, name: str) -> HgRepository:
|
|
return self.create_hg_repo(name)
|
|
|
|
def populate_repo(self) -> None:
|
|
self.repo.write_file("file", "hello world!\n")
|
|
self.repo.commit("Initial commit.")
|
|
|
|
def poll_until_counter_condition(
|
|
self, assertion_condition: typing.Callable[[Counters], None]
|
|
) -> None:
|
|
timeout_seconds = 2.0
|
|
poll_interval_seconds = 0.1
|
|
deadline = time.monotonic() + timeout_seconds
|
|
while True:
|
|
counters = self.get_counters()
|
|
try:
|
|
assertion_condition(counters)
|
|
break
|
|
except AssertionError as e:
|
|
if time.monotonic() >= deadline:
|
|
raise
|
|
logger.info(
|
|
f"Assertion failed. Waiting {poll_interval_seconds} "
|
|
f"seconds before trying again. {e}"
|
|
)
|
|
time.sleep(poll_interval_seconds)
|
|
continue
|
|
|
|
|
|
class HgBackingStoreStatsTest(testcase.EdenRepoTest):
|
|
def test_reading_file_gets_file_from_hg(self) -> None:
|
|
counters_before = self.get_counters()
|
|
path = Path(self.mount) / "dir" / "subdir" / "file"
|
|
path.read_bytes()
|
|
counters_after = self.get_counters()
|
|
|
|
self.assertEqual(
|
|
counters_after.get("store.hg.get_file.count", 0),
|
|
counters_before.get("store.hg.get_file.count", 0) + 1,
|
|
f"Reading {path} should increment store.hg.get_file.count",
|
|
)
|
|
|
|
def create_repo(self, name: str) -> HgRepository:
|
|
return self.create_hg_repo(name)
|
|
|
|
def populate_repo(self) -> None:
|
|
# This file evades EdenFS' automatic prefetching by being two levels
|
|
# inside the root.
|
|
self.repo.write_file("dir/subdir/file", "hello world!\n")
|
|
|
|
self.repo.commit("Initial commit.")
|
|
|
|
|
|
class HgImporterStatsTest(testcase.EdenRepoTest):
|
|
def test_reading_file_imports_blob(self) -> None:
|
|
counters_before = self.get_counters()
|
|
path = Path(self.mount) / "dir" / "subdir" / "file"
|
|
path.read_bytes()
|
|
counters_after = self.get_counters()
|
|
|
|
self.assertEqual(
|
|
counters_after.get("hg_importer.cat_file.count", 0),
|
|
counters_before.get("hg_importer.cat_file.count", 0) + 1,
|
|
f"Reading {path} should increment hg_importer.cat_file.count",
|
|
)
|
|
|
|
def create_repo(self, name: str) -> HgRepository:
|
|
return self.create_hg_repo(name)
|
|
|
|
def populate_repo(self) -> None:
|
|
# This file evades EdenFS' automatic prefetching by being two levels
|
|
# inside the root.
|
|
self.repo.write_file("dir/subdir/file", "hello world!\n")
|
|
|
|
self.repo.commit("Initial commit.")
|