mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 00:14:35 +03:00
5b47f5a7bd
There are race conditions between clients performing a shared clone to pooled storage: 1) Clients race to create the new shared repo in the pool directory 2) 1 client is seeding the repo in the pool directory and another goes to share it before it is fully cloned We prevent these race conditions by obtaining a lock in the pool directory that is derived from the name of the repo we will be accessing. To test this, a simple generic "lockdelay" extension has been added. The extension inserts an optional, configurable delay before or after lock acquisition. In the test, we delay 2 seconds after lock acquisition in the first process and 1 second before lock acquisition in the 2nd process. This means the first process has 1s to obtain the lock. There is a race condition here. If we encounter it in the wild, we could change the dummy extension to wait on the lock file to appear instead of relying on timing. But that's more complicated. Let's see what happens first.
27 lines
638 B
Python
27 lines
638 B
Python
# Dummy extension that adds a delay after acquiring a lock.
|
|
#
|
|
# This extension can be used to test race conditions between lock acquisition.
|
|
|
|
from __future__ import absolute_import
|
|
|
|
import os
|
|
import time
|
|
|
|
from mercurial import (
|
|
lock as lockmod,
|
|
)
|
|
|
|
class delaylock(lockmod.lock):
|
|
def lock(self):
|
|
delay = float(os.environ.get('HGPRELOCKDELAY', '0.0'))
|
|
if delay:
|
|
time.sleep(delay)
|
|
res = super(delaylock, self).lock()
|
|
delay = float(os.environ.get('HGPOSTLOCKDELAY', '0.0'))
|
|
if delay:
|
|
time.sleep(delay)
|
|
return res
|
|
|
|
def extsetup(ui):
|
|
lockmod.lock = delaylock
|