mirror of
https://github.com/facebook/sapling.git
synced 2024-10-08 07:49:11 +03:00
7995ae5e85
Summary: This diff adds an (as yet unused) option to log verbose scuba samples. Here's the high-level overview. In addition to doing `scuba_sample.log_with_msg` and `scuba_sample.log()`, you can now do `scuba_sample.log_with_msg_verbose()` and `scuba_sample.log_verbose()`. These two methods indicate that the intended sample is verbose and should go through some filtering prior to logging. By default verbose samples are just not logged, but there are ways to override this via `ScubaObservabilityConfig`. Namely, the config has a "system" `ScubaVerbosityLevel`, which is either `Normal` or `Verbose`. When the level is `Verbose`, all samples are logged (those triggered by `.log_with_msg()`, `.log()`, `.log_with_msg_verbose()` and `.log_verbose()`. In addition to the "system" verbosity level, `ScubaObservabilityConfig` supports a few filtering overrides: a list of verbose sessions, a list of verbose unixnames and a list of verbose hostnames. Whenever a verbose sample's session, unixname or source hostname belongs to a corresponding list, the sample is logged. `ScubaObservabilityConfig` is a struct, queried from `configerator` without the need to restart a service. Querying/figuring out whether logging is needed is done by the `ObservabilityContext` struct, which was introduced a few diffs earlier. Note: I also want to add regex-based filtering for hostnames, as it's likely to be more useful than exact-match filtering, but I will do that later. Reviewed By: StanislavGlebik Differential Revision: D25232429 fbshipit-source-id: 057af95fc31f70d796063cefac5b8f7c69d7b3ef |
||
|---|---|---|
| .. | ||
| allocation_tracing | ||
| async_limiter | ||
| bounded_traversal | ||
| dedupmap | ||
| iterhelpers | ||
| rust | ||
| scribe_ext | ||
| scuba_ext | ||
| sql_construct | ||
| topo_sort | ||
| type_map | ||
| uniqueheap | ||