mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 01:07:15 +03:00
a47464f60d
Summary: At the moment CommitSyncConfig can be set in two ways: 1) Set in the normal mononoke config. That means that config can be updated only after a service is restarted. This is an outdated way, and won't be used in prod. 2) Set in separate config which can be updated on demand. This is what we are planning to use in production. create_commit_syncer_from_matches was used to build a CommitSyncer object via normal mononoke config (i.e. outdated option #1). According to the comments it was done so that we can read configs from the disk instead of configerator, but this doesn't make sense because you already can read configerator configs from disk. So create_commit_syncer_from_matches doesn't look particularly useful, and besides it also make further refactorings harder. Let's remove it. Reviewed By: ikostia Differential Revision: D23811090 fbshipit-source-id: 114d88d9d9207c831d98dfa1cbb9e8ede5adeb1d |
||
---|---|---|
.. | ||
src | ||
Cargo.toml |