sapling/eden/scm/Makefile
Mark Shroyer 33ba7d3fac Remove Cargo.lock on make clean (#534)
Summary:
[sapling] Remove Cargo.lock on `make clean`
The help text for `make clean` says:

> remove files created by other targets
> (except installed files or dist source tarball)

So I'd expect it to remove any non-installed built state like Cargo.toml.

Concretely, I was surprised by this behavior when the build failed after
pulling in updates, even after running `gmake clean`.  My Cargo.lock from a
previous build had pinned the watchman_client crate to an old version, but the
updated workingcopy crate relied on the addition of `BytesNameField` to
watchman_client@main.

I think it would be better if autocargo generated a Cargo.lock for us from the
Buck versions of dependencies, but as long as it's being generated as a build
artifact it should be removed by `make clean`.

Pull Request resolved: https://github.com/facebook/sapling/pull/534

Test Plan:
```
% cd eden/scm
% gmake oss
% ls Cargo.lock
Cargo.lock
% gmake clean
% ls Cargo.lock
% ls: Cargo.lock: No such file or directory
```

 ---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/534).
* __->__ https://github.com/facebook/sapling/issues/534

Reviewed By: quark-zju

Differential Revision: D43478239

Pulled By: mshroyer

fbshipit-source-id: 2c472a0e1d86c85994191e242337dab8249bafaa
2023-02-23 11:19:12 -08:00

217 lines
7.4 KiB
Makefile

# Portions Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2.
# Copyright Olivia Mackall <olivia@selenic.com> and others
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
# If you want to change PREFIX, do not just edit it below. The changed
# value wont get passed on to recursive make calls. You should instead
# override the variable on the command like:
#
# % make PREFIX=/opt/ install
export PREFIX=/usr/local
ifeq ($(OS),Windows_NT)
PYTHON := python
else
PYTHON := python2
endif
PYTHON3 := python3
ifeq ($(RUST_DEBUG),1)
RUST_FLAG = --debug
endif
$(eval HGROOT := $(shell pwd))
HGPYTHONS ?= $(HGROOT)/build/pythons
PURE=
PYFILES:=$(shell find mercurial ext -name '*.py' 2>/dev/null)
DOCFILES=edenscm/help/*.txt
export LANGUAGE=C
export LC_ALL=C
TESTFLAGS ?= $(shell echo $$HGTESTFLAGS)
OSXVERSIONFLAGS ?= $(shell echo $$OSXVERSIONFLAGS)
HGNAME ?= hg
SL_NAME = sl
# Set this to e.g. "mingw32" to use a non-default compiler.
COMPILER=
COMPILERFLAG_tmp_ =
COMPILERFLAG_tmp_${COMPILER} ?= -c $(COMPILER)
COMPILERFLAG=${COMPILERFLAG_tmp_${COMPILER}}
# Mac Big Sur doesn't find the standard library without this.
export SDKROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk
help:
@echo 'Commonly used make targets:'
@echo ' all - build program'
@echo ' install - install program and man pages to $$PREFIX ($(PREFIX))'
@echo ' install-home - install with setup.py install --home=$$HOME ($(HOME))'
@echo ' local - build for inplace usage'
@echo ' tests - run all tests in the automatic test suite'
@echo ' test-foo - run only specified tests (e.g. test-merge1.t)'
@echo ' dist - run all tests and create a source tarball in dist/'
@echo ' clean - remove files created by other targets'
@echo ' (except installed files or dist source tarball)'
@echo ' update-pot - update i18n/hg.pot'
@echo
@echo 'Example for a system-wide installation under /usr/local:'
@echo ' make all && su -c "make install" && hg version'
@echo
@echo 'Example for a local installation (usable in this directory):'
@echo ' make local && ./hg version'
all: build
oss:
SAPLING_OSS_BUILD=true HGNAME=$(SL_NAME) \
$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) setup.py $(PURE) \
build_interactive_smartlog \
build_py -c -d . \
build_clib $(COMPILERFLAG) \
build_ext $(COMPILERFLAG) -i \
build_rust_ext -i -l $(RUST_FLAG) \
build_pyzip -i \
build_mo
ifeq ($(OS),Windows_NT)
cp build/scripts-3*/$(SL_NAME).exe $(SL_NAME).exe
else
$(RM) $(SL_NAME)
cp build/scripts-3*/$(SL_NAME) $(SL_NAME)
endif
install-oss: oss
SAPLING_OSS_BUILD=true HGNAME=$(SL_NAME) \
$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) setup.py $(PURE) \
install --root="$(DESTDIR)/" --prefix="$(PREFIX)" \
--install-lib="$(PREFIX)"/lib/python3.$(shell $(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) -c "import sys; print(sys.version_info.minor)")/site-packages \
--install-scripts="$(PREFIX)/bin" --force
local:
$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) setup.py $(PURE) \
build_py -c -d . \
build_clib $(COMPILERFLAG) \
build_ext $(COMPILERFLAG) -i \
build_rust_ext -i -l $(RUST_FLAG) \
build_pyzip -i \
build_mo
ifeq ($(OS),Windows_NT)
cp build/scripts-3*/$(HGNAME).exe $(HGNAME).exe
else
$(RM) $(HGNAME)
cp build/scripts-3*/$(HGNAME) $(HGNAME)
endif
build:
$(PYTHON) setup.py $(PURE) build $(COMPILERFLAG)
deb:
./packaging/debian/build_deb.sh
rpm:
rpmbuild \
--define "sapling_root `pwd`" \
--define "version $(VERSION)" \
-bb packaging/rpm/sapling.spec
wheel:
FORCE_SETUPTOOLS=1 $(PYTHON) setup.py $(PURE) bdist_wheel $(COMPILERFLAG)
getdepsbuild:
mkdir -p $(GETDEPS_BUILD_DIR)/eden_scm
ln -sfn $(GETDEPS_BUILD_DIR)/eden_scm build
GETDEPS_BUILD=1 \
PYTHON_SYS_EXECUTABLE=$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) \
THRIFT="$(GETDEPS_INSTALL_DIR)/fbthrift/bin/thrift1" \
$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) setup.py \
$(PURE) build $(COMPILERFLAG)
cleanbutpackages:
-$(PYTHON3) setup.py clean --all # ignore errors from this command
find contrib doc i18n edenscm edenscmnative tests \
\( -name '*.py[cdo]' -o -name '*.so' \) -exec rm -f '{}' ';'
rm -f MANIFEST MANIFEST.in edenscm/ext/__index__.py tests/*.err
rm -f edenscm/__modulepolicy__.py
if test -d .hg; then rm -f edenscm/__version__.py; fi
rm -rf build/*
rm -rf build edenscm/locale
rm -f Cargo.lock
ifeq ($(OS),Windows_NT)
$(RM) -r hg-python $(HGNAME).exe python27.dll
else
$(RM) $(HGNAME)
endif
clean: cleanbutpackages
rm -rf packages
install: build
$(PYTHON) setup.py $(PURE) install --root="$(DESTDIR)/" --prefix="$(PREFIX)" --force
install-home: build
$(PYTHON) setup.py $(PURE) install --home="$(HOME)" --prefix="" --force
install-getdeps: getdepsbuild
PYTHON_SYS_EXECUTABLE=$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) \
GETDEPS_BUILD=1 $(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) \
setup.py $(PURE) install --root="$(DESTDIR)/" --prefix="$(PREFIX)" --install-lib="$(PREFIX)/bin" --force
test-getdeps: install-getdeps
# Run one test to check the binary is minimally good as will be used later in Mononoke getdeps tests
# Running all the tests requires a bit of filtering to run the good set (or deleting flaky ones)
cd tests && PYTHON_SYS_EXECUTABLE=$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) \
$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) run-tests.py -j1 --getdeps-build --with-hg="$(PREFIX)/bin/$(HGNAME)" test-status.t test-convert.t
check: tests
.PHONY: tests
tests:
cd tests && PYTHON_SYS_EXECUTABLE=$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) \
$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) run-tests.py
update-pot: i18n/hg.pot
i18n/hg.pot: $(PYFILES) $(DOCFILES) i18n/posplit i18n/hggettext
$(PYTHON) i18n/hggettext edenscm/commands.py \
edenscm/ext/*.py edenscm/ext/*/__init__.py \
edenscm/fileset.py edenscm/revset.py \
edenscm/templatefilters.py edenscm/templatekw.py \
edenscm/templater.py \
edenscm/filemerge.py \
edenscm/util.py \
$(DOCFILES) > i18n/hg.pot.tmp
# All strings marked for translation in Mercurial contain
# ASCII characters only. But some files contain string
# literals like this '\037\213'. xgettext thinks it has to
# parse them even though they are not marked for translation.
# Extracting with an explicit encoding of ISO-8859-1 will make
# xgettext "parse" and ignore them.
echo $(PYFILES) | xargs \
xgettext --package-name "Mercurial" \
--msgid-bugs-address "<mercurial-devel@mercurial-scm.org>" \
--copyright-holder "Olivia Mackall <olivia@selenic.com> and others" \
--from-code ISO-8859-1 --join --sort-by-file --add-comments=i18n: \
--keyword=_n:1,2 -d hg -p i18n -o hg.pot.tmp
$(PYTHON) i18n/posplit i18n/hg.pot.tmp
# The target file is not created before the last step. So it never is in
# an intermediate state.
mv -f i18n/hg.pot.tmp i18n/hg.pot
%.po: i18n/hg.pot
# work on a temporary copy for never having a half completed target
cp $@ $@.tmp
msgmerge --no-location --update $@.tmp $^
mv -f $@.tmp $@
# Packaging targets
.PHONY: help all local build cleanbutpackages clean install install-home install-getdeps getdepsbuild deb