mirror of
https://github.com/facebook/sapling.git
synced 2024-10-07 15:27:13 +03:00
2f9545c92c
After 08202d1ef738 I see: $ hg id -q largefiles: repo method 'commit' appears to have already been wrapped by another extension: largefiles may behave incorrectly largefiles: repo method 'push' appears to have already been wrapped by another extension: largefiles may behave incorrectly 3bd0c95ec1bf The warning is bad: * The message gives no hint what the problem is and how it can be resolved. The message is useless. * Largefiles do have its share of problems, but I don't think I ever have seen a problem where this warning would have helped. The 'may' in the warning seems like an exaggeration of the risk. Having largefiles enabled in combination with for instance mq, hggit and hgsubversion causes a warning (depending on the configuration order) but do not cause problems. Extensions might of course be incompatible, but they can be that in many other ways. The check and the message are incorrect. It would thus be better to remove the check and the warning completely. Before 08202d1ef738 the check always failed. That change made the check work more like intended ... but the intention was wrong. This change will thus also back that change out. |
||
---|---|---|
.. | ||
__init__.py | ||
basestore.py | ||
CONTRIBUTORS | ||
lfcommands.py | ||
lfutil.py | ||
localstore.py | ||
overrides.py | ||
proto.py | ||
remotestore.py | ||
reposetup.py | ||
uisetup.py | ||
wirestore.py |