mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 08:47:12 +03:00
6b48086887
Summary: The high level goal is to test new unodes functionality. In particular, we want to test `list_directory()` functionality. There's a problem though - `list_directory()` returns Nodehash and filetype for each entry it returns. That's cheap to do with mercurial manifests but not cheap with unodes: 1) Mercurial manifests store filetype (i.e. whether it's a file, symlink or executable) in manifests. But we don't store it in unode manifests (it's stored in a separate file unode entry). 2) Unodes don't have mercurial hashes at all. However there's currently a single user of `list_directory()` call - this is scmquery - and it just discards both of the fields - https://fburl.com/8vr5hibo. So I decided to introduce a separate `list_directory_unodes()` method that returns a list of directory entries without any additional info. The plan is to use it in scmquery for repos that already has unodes backfilled. That's intended to be short-term - ideally we replace current thrift interface with something more modern or at the very least replace `list_directory` with `list_directory_unodes()` completely. Reviewed By: farnz Differential Revision: D16918232 fbshipit-source-id: f05185be8eecbf0852c7ddb0a482d4a5a63f8b53 |
||
---|---|---|
.. | ||
if | ||
mocks | ||
src | ||
Cargo.toml |