sapling/eden/fs/store/LocalStore.cpp
Adam Simpkins 1f52adbca4 fix a crash on tree import error
Summary:
Fix HgManifestImporter to always call LocalStore::disableBatchMode()
after calling enableBatchMode().  Previously if an error occurred importing a
tree disableBatchMode() would never be called, resulting in a crash when
enableBatchMode() was called the next time we tried to import a tree.

This API is still not thread-safe, and will break if multiple callers try to
use the enableBatchMode/disableBatchMode APIs simultaneously.  In the future we
should move the batch functionality to a separate class, so each caller that
wants to do batching manages their own write batch, and this isn't controlled
globally for LocalStore.

Reviewed By: wez

Differential Revision: D5365958

fbshipit-source-id: 0616f0af5029de6ebdfee768b8fddda5b6d2dfd1
2017-07-05 11:21:30 -07:00

427 lines
12 KiB
C++

/*
* Copyright (c) 2016-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
*/
#include "LocalStore.h"
#include <folly/Bits.h>
#include <folly/Format.h>
#include <folly/Optional.h>
#include <folly/String.h>
#include <folly/experimental/logging/xlog.h>
#include <folly/io/Cursor.h>
#include <folly/io/IOBuf.h>
#include <rocksdb/db.h> // @manual=@/rocksdb:rocksdb
#include <array>
#include "eden/fs/model/Blob.h"
#include "eden/fs/model/Tree.h"
#include "eden/fs/model/git/GitBlob.h"
#include "eden/fs/model/git/GitTree.h"
#include "eden/fs/rocksdb/RocksDbUtil.h"
#include "eden/fs/rocksdb/RocksException.h"
#include "eden/fs/store/StoreResult.h"
using facebook::eden::Hash;
using folly::ByteRange;
using folly::io::Cursor;
using folly::IOBuf;
using folly::Optional;
using folly::StringPiece;
using rocksdb::ReadOptions;
using rocksdb::Slice;
using rocksdb::SliceParts;
using rocksdb::WriteBatch;
using rocksdb::WriteOptions;
using std::string;
using std::unique_ptr;
namespace {
using namespace facebook::eden;
/**
* For each blob, we also store an entry containing the blob metadata.
* This is stored under a key that is the blob's key plus the
* ATTRIBUTE_METADATA suffix.
*
* (We should potentially switch to RocksDB column families instead in the
* future, rather than using a key suffix.)
*/
const unsigned char ATTRIBUTE_METADATA = 'x';
class BlobMetadataKey {
public:
explicit BlobMetadataKey(const Hash& id) {
memcpy(key_.data(), id.getBytes().data(), Hash::RAW_SIZE);
key_[Hash::RAW_SIZE] = ATTRIBUTE_METADATA;
}
ByteRange bytes() const {
return ByteRange(key_.data(), key_.size());
}
Slice slice() const {
return Slice{reinterpret_cast<const char*>(key_.data()), key_.size()};
}
private:
std::array<uint8_t, Hash::RAW_SIZE + 1> key_;
};
class SerializedBlobMetadata {
public:
explicit SerializedBlobMetadata(const BlobMetadata& metadata) {
serialize(metadata.sha1, metadata.size);
}
SerializedBlobMetadata(const Hash& contentsHash, uint64_t blobSize) {
serialize(contentsHash, blobSize);
}
Slice slice() const {
return Slice{reinterpret_cast<const char*>(data_.data()), data_.size()};
}
static BlobMetadata parse(Hash blobID, const StoreResult& result) {
auto bytes = result.bytes();
if (bytes.size() != SIZE) {
throw std::invalid_argument(folly::sformat(
"Blob metadata for {} had unexpected size {}. Could not deserialize.",
blobID.toString(),
bytes.size()));
}
uint64_t blobSizeBE;
memcpy(&blobSizeBE, bytes.data(), sizeof(uint64_t));
bytes.advance(sizeof(uint64_t));
auto contentsHash = Hash{bytes};
return BlobMetadata{contentsHash, folly::Endian::big(blobSizeBE)};
}
private:
void serialize(const Hash& contentsHash, uint64_t blobSize) {
uint64_t blobSizeBE = folly::Endian::big(blobSize);
memcpy(data_.data(), &blobSizeBE, sizeof(uint64_t));
memcpy(
data_.data() + sizeof(uint64_t),
contentsHash.getBytes().data(),
Hash::RAW_SIZE);
}
static constexpr size_t SIZE = sizeof(uint64_t) + Hash::RAW_SIZE;
/**
* The serialized data is stored as stored as:
* - size (8 bytes, big endian)
* - hash (20 bytes)
*/
std::array<uint8_t, SIZE> data_;
};
rocksdb::Slice _createSlice(folly::ByteRange bytes) {
return Slice(reinterpret_cast<const char*>(bytes.data()), bytes.size());
}
}
namespace facebook {
namespace eden {
LocalStore::LocalStore(AbsolutePathPiece pathToRocksDb)
: db_(createRocksDb(pathToRocksDb.stringPiece())) {}
LocalStore::~LocalStore() {
#ifdef FOLLY_SANITIZE_ADDRESS
// RocksDB has some race conditions around setting up and tearing down
// the threads that it uses to maintain the database. This manifests
// in our test harness, particularly in a test where we quickly mount
// and then unmount. We see this as an abort with the message:
// "pthread lock: Invalid Argument".
// My assumption is that we're shutting things down before rocks has
// completed initializing. This sleep call is present in the destructor
// to make it more likely that rocks is past that critical point and
// so that we can shutdown successfully.
/* sleep override */ sleep(1);
#endif
}
StoreResult LocalStore::get(ByteRange key) const {
string value;
flushForRead();
auto status = db_.get()->Get(ReadOptions(), _createSlice(key), &value);
if (!status.ok()) {
if (status.IsNotFound()) {
// Return an empty StoreResult
return StoreResult();
}
// TODO: RocksDB can return a "TryAgain" error.
// Should we try again for the user, rather than re-throwing the error?
// We don't use RocksException::check(), since we don't want to waste our
// time computing the hex string of the key if we succeeded.
throw RocksException::build(
status, "failed to get ", folly::hexlify(key), " from local store");
}
return StoreResult(std::move(value));
}
StoreResult LocalStore::get(const Hash& id) const {
return get(id.getBytes());
}
// TODO(mbolin): Currently, all objects in our RocksDB are Git objects. We
// probably want to namespace these by column family going forward, at which
// point we might want to have a GitLocalStore that delegates to an
// LocalStore so a vanilla LocalStore has no knowledge of deserializeGitTree()
// or deserializeGitBlob().
std::unique_ptr<Tree> LocalStore::getTree(const Hash& id) const {
auto result = get(id.getBytes());
if (!result.isValid()) {
return nullptr;
}
return deserializeGitTree(id, result.bytes());
}
std::unique_ptr<Blob> LocalStore::getBlob(const Hash& id) const {
// We have to hold this string in scope while we deserialize and build
// the blob; otherwise, the results are undefined.
auto result = get(id.getBytes());
if (!result.isValid()) {
return nullptr;
}
auto buf = result.extractIOBuf();
return deserializeGitBlob(id, &buf);
}
Optional<BlobMetadata> LocalStore::getBlobMetadata(const Hash& id) const {
BlobMetadataKey key(id);
auto result = get(key.bytes());
if (!result.isValid()) {
return folly::none;
}
return SerializedBlobMetadata::parse(id, result);
}
Optional<Hash> LocalStore::getSha1ForBlob(const Hash& id) const {
auto metadata = getBlobMetadata(id);
if (!metadata) {
return folly::none;
}
return metadata.value().sha1;
}
BlobMetadata LocalStore::putBlob(const Hash& id, const Blob* blob) {
const IOBuf& contents = blob->getContents();
BlobMetadata metadata{Hash::sha1(&contents),
contents.computeChainDataLength()};
if (hasKey(id)) {
return metadata;
}
BlobMetadataKey metadataKey(id);
SerializedBlobMetadata metadataBytes(metadata);
auto hashSlice = _createSlice(id.getBytes());
SliceParts keyParts(&hashSlice, 1);
ByteRange bodyBytes;
// Add a git-style blob prefix
auto prefix = folly::to<string>("blob ", contents.computeChainDataLength());
prefix.push_back('\0');
std::vector<Slice> bodySlices;
bodySlices.emplace_back(prefix);
// Add all of the IOBuf chunks
Cursor cursor(&contents);
while (true) {
auto bytes = cursor.peekBytes();
if (bytes.empty()) {
break;
}
bodySlices.push_back(_createSlice(bytes));
cursor.skip(bytes.size());
}
SliceParts bodyParts(bodySlices.data(), bodySlices.size());
{
auto pending = pending_.wlock();
if (!pending->writeBatch) {
pending->writeBatch = std::make_unique<WriteBatch>(writeBatchBufferSize_);
}
pending->writeBatch->Put(keyParts, bodyParts);
pending->writeBatch->Put(metadataKey.slice(), metadataBytes.slice());
if (writeBatchBufferSize_ > 0) {
// Only track the inserted keys in batch mode
pending->batchedKeys.insert(StringPiece{id.getBytes()});
pending->batchedKeys.insert(StringPiece{metadataKey.bytes()});
}
}
flushIfNotBatch();
return metadata;
}
std::pair<Hash, folly::IOBuf> LocalStore::serializeTree(
const Tree* tree) const {
GitTreeSerializer serializer;
for (auto& entry : tree->getTreeEntries()) {
serializer.addEntry(std::move(entry));
}
IOBuf treeBuf = serializer.finalize();
auto id = tree->getHash();
if (id == Hash()) {
id = Hash::sha1(&treeBuf);
}
return std::make_pair(id, treeBuf);
}
Hash LocalStore::putTree(const Tree* tree) {
auto serialized = serializeTree(tree);
ByteRange treeData = serialized.second.coalesce();
auto& id = serialized.first;
put(id.getBytes(), treeData);
return id;
}
void LocalStore::put(const Hash& id, folly::ByteRange value) {
put(id.getBytes(), value);
}
void LocalStore::put(folly::ByteRange key, folly::ByteRange value) {
if (hasKey(key)) {
// Don't try to overwrite an existing key
return;
}
{
auto pending = pending_.wlock();
if (!pending->writeBatch) {
pending->writeBatch = std::make_unique<WriteBatch>(writeBatchBufferSize_);
}
pending->writeBatch->Put(_createSlice(key), _createSlice(value));
if (writeBatchBufferSize_ > 0) {
// Only track the inserted keys in batch mode
pending->batchedKeys.insert(StringPiece{key});
}
}
flushIfNotBatch();
}
void LocalStore::flushIfNotBatch() {
bool needFlush = writeBatchBufferSize_ == 0;
if (!needFlush) {
auto pending = pending_.wlock();
if (!pending->writeBatch) {
return;
}
needFlush = pending->writeBatch->GetDataSize() >= writeBatchBufferSize_;
}
if (needFlush) {
flush();
}
}
void LocalStore::enableBatchMode(size_t bufferSize) {
// FIXME: This code is not thread safe. This doesn't lock around
// writeBatchBufferSize_, and this API assumes that only a single external
// caller tries to manage batch mode.
CHECK_EQ(writeBatchBufferSize_, 0) << "Must not already be in batch mode";
writeBatchBufferSize_ = bufferSize;
}
void LocalStore::disableBatchMode() {
CHECK_NE(writeBatchBufferSize_, 0) << "Should not already be in batch mode";
writeBatchBufferSize_ = 0;
pending_.wlock()->batchedKeys.clear();
flush();
}
void LocalStore::flush() {
auto pending = pending_.wlock();
if (!pending->writeBatch) {
return;
}
XLOG(DBG5) << "Flushing " << pending->writeBatch->Count()
<< " entries with data size of "
<< pending->writeBatch->GetDataSize();
auto status = db_->Write(WriteOptions(), pending->writeBatch.get());
XLOG(DBG5) << "... Flushed";
pending->writeBatch.reset();
if (!status.ok()) {
throw RocksException::build(
status, "error putting blob batch in local store");
}
}
void LocalStore::flushForRead() const {
auto pending = pending_.wlock();
if (!pending->writeBatch) {
return;
}
XLOG(DBG5) << "READ op: Flushing " << pending->writeBatch->Count()
<< " entries with data size of "
<< pending->writeBatch->GetDataSize();
auto status = db_->Write(WriteOptions(), pending->writeBatch.get());
XLOG(DBG5) << "... Flushed";
pending->writeBatch.reset();
if (!status.ok()) {
throw RocksException::build(
status, "error putting blob batch in local store");
}
}
bool LocalStore::hasKey(folly::ByteRange key) const {
{
auto pending = pending_.rlock();
auto keyStr = StringPiece{key};
if (pending->batchedKeys.find(keyStr) != pending->batchedKeys.end()) {
return true;
}
}
string value;
auto status = db_.get()->Get(ReadOptions(), _createSlice(key), &value);
if (!status.ok()) {
if (status.IsNotFound()) {
return false;
}
// TODO: RocksDB can return a "TryAgain" error.
// Should we try again for the user, rather than re-throwing the error?
// We don't use RocksException::check(), since we don't want to waste our
// time computing the hex string of the key if we succeeded.
throw RocksException::build(
status, "failed to get ", folly::hexlify(key), " from local store");
}
return true;
}
bool LocalStore::hasKey(const Hash& id) const {
return hasKey(id.getBytes());
}
}
}