mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 00:45:18 +03:00
3285a8f909
Summary:
Now that fmt is available in Folly builds (D14813810), use it to reduce binary code size in Folly Logger. This is done by moving most of the formatting logic behind the type-erased `vformat` API. Previously it was instantiated for all combinations of formatting argument types used in calls to `FB_LOGF` and `XLOGF` in a program.
The effect of this change can be illustrated by looking at symbol sizes as given by `nm -S -td` for the following test function:
```
void test_log() {
FB_LOGF(logger, WARN, "num events: {:06d}, duration: {:6.3f}", 1234, 5.6789);
}
```
compiled in `opt` mode.
`nm` before:
```
0000000004236736 0000000000000231 T test_log()
0000000004236992 0000000000001002 W std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > folly::LogStreamProcessor::formatLogString<int, double>(folly::Range<char const*>, int const&, double const&)
```
`nm` after:
```
0000000004237536 0000000000000231 T test_log()
0000000004237792 0000000000000251 W std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > folly::LogStreamProcessor::formatLogString<int, double>(folly::Range<char const*>, int const&, double const&)
0000000004238048 0000000000000740 W folly::LogStreamProcessor::vformatLogString[abi:cxx11](folly::Range<char const*>, fmt::v5::format_args, bool&)
```
Before we had one 1002 byte instantiation of `formatLogString<int, double>`. With this change it was reduced 4x to 251 bytes and non-template function `vformatLogString` was added which is shared among all logging calls. The size of `test_log` remained unchanged. There are even bigger savings from Folly Formatter instantiations which are no longer needed, e.g.
```
0000000004238032 0000000000001363 W _ZNK5folly13BaseFormatterINS_9FormatterILb0EJRKiRKdEEELb0EJS3_S5_EEclIZNKS7_8appendToINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEENSt9enable_ifIXsr12IsSomeStringIT_EE5valueEvE4typeERSH_EUlNS_5RangeIPKcEEE_EEvSK_
```
So in total this change results in ~5x per-call/instantiation binary size. It is possible to reduce binary size even further but it is not done in the current diff to keep it manageable.
In addition to binary size improvements, switching to fmt will potentially
* allow catching errors in format strings at compile time,
* simplify future migration to C++20 [`std::format`](http://eel.is/c++draft/format).
Reviewed By: simpkins
Differential Revision: D15485589
fbshipit-source-id: 06db4436839f11c2c3dbed7b36658e2193343411
|
||
|---|---|---|
| .. | ||
| test | ||
| BucketedLog.h | ||
| Bug.cpp | ||
| Bug.h | ||
| ChronoParse.cpp | ||
| ChronoParse.h | ||
| ChronoUnit.cpp | ||
| ChronoUnit.gperf | ||
| ChronoUnit.h | ||
| Clock.cpp | ||
| Clock.h | ||
| CMakeLists.txt | ||
| CoverageSet.cpp | ||
| CoverageSet.h | ||
| DirType.h | ||
| FaultInjector.cpp | ||
| FaultInjector.h | ||
| FutureSubprocess.cpp | ||
| FutureSubprocess.h | ||
| FutureUnixSocket.cpp | ||
| FutureUnixSocket.h | ||
| IDGen.cpp | ||
| IDGen.h | ||
| IoFuture.cpp | ||
| IoFuture.h | ||
| LazyInitialize.h | ||
| LeaseCache.h | ||
| MappedDiskVector.h | ||
| Memory.h | ||
| PathFuncs.cpp | ||
| PathFuncs.h | ||
| PathMap.h | ||
| ProcessAccessLog.cpp | ||
| ProcessAccessLog.h | ||
| ProcessNameCache.cpp | ||
| ProcessNameCache.h | ||
| ProcUtil.cpp | ||
| ProcUtil.h | ||
| ServiceAddress.cpp | ||
| ServiceAddress.h | ||
| SortedInsert.h | ||
| SSLContext.cpp | ||
| SSLContext.h | ||
| StatTimes.h | ||
| Synchronized.h | ||
| SystemError.h | ||
| TimeUtil.cpp | ||
| TimeUtil.h | ||
| UnboundedQueueExecutor.cpp | ||
| UnboundedQueueExecutor.h | ||
| UnixSocket.cpp | ||
| UnixSocket.h | ||
| XAttr.cpp | ||
| XAttr.h | ||