mirror of
https://github.com/facebook/sapling.git
synced 2024-10-06 23:07:18 +03:00
33ba7d3fac
Summary: [sapling] Remove Cargo.lock on `make clean` The help text for `make clean` says: > remove files created by other targets > (except installed files or dist source tarball) So I'd expect it to remove any non-installed built state like Cargo.toml. Concretely, I was surprised by this behavior when the build failed after pulling in updates, even after running `gmake clean`. My Cargo.lock from a previous build had pinned the watchman_client crate to an old version, but the updated workingcopy crate relied on the addition of `BytesNameField` to watchman_client@main. I think it would be better if autocargo generated a Cargo.lock for us from the Buck versions of dependencies, but as long as it's being generated as a build artifact it should be removed by `make clean`. Pull Request resolved: https://github.com/facebook/sapling/pull/534 Test Plan: ``` % cd eden/scm % gmake oss % ls Cargo.lock Cargo.lock % gmake clean % ls Cargo.lock % ls: Cargo.lock: No such file or directory ``` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/534). * __->__ https://github.com/facebook/sapling/issues/534 Reviewed By: quark-zju Differential Revision: D43478239 Pulled By: mshroyer fbshipit-source-id: 2c472a0e1d86c85994191e242337dab8249bafaa |
||
|---|---|---|
| .. | ||
| fs | ||
| integration | ||
| locale | ||
| mononoke | ||
| scm | ||
| test_support | ||
| test-data | ||
| testlib | ||
| .clang-tidy | ||
| .gitignore | ||
| .mononoke_test_file | ||
| Eden.project.toml | ||