mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 01:07:15 +03:00
341b4f1bc3
Summary: The API expects a stream of filenodes to insert, but we actually never used that ability. Instead, every single callsites has a `Vec`, which it converts to a stream and passes that in. I'd like to change this for two reasons: - It's un-necessary - It makes the code more complex on the Filenodes implementation side, and less efficient, since we need to `chunk()` there in small chunks, which might not all be in the same shard. If we get the entire `Vec` at once, we can chunk on a per-shard basis (this happens later in this stack). Besides, if we end up having a stream and wanting the old behavior, we can always call `chunk()` the stream and call `add_filenodes` on each batch (which is actually nicer because if you have a futures 0.2 stream that isn't static, you can do this, but you can't turn it into a `BoxStream`!). Reviewed By: StanislavGlebik Differential Revision: D19902537 fbshipit-source-id: a4c030c4a51afbb6e9db133b32464009eed197af |
||
---|---|---|
.. | ||
blame | ||
deleted_files_manifest | ||
fastlog | ||
filenodes | ||
fsnodes | ||
mercurial_derived_data | ||
src | ||
unodes | ||
utils |