sapling/eden/fs/prjfs
Xavier Deguillard 34edb7b618 win: re-use guid for the lifetime of the checkout
Summary:
On Windows, the GUID of the mount point identifies the virtualization instance,
that GUID is then propagated automatically to the created placeholders when
these are created as a response to a getPlaceholderInfo callback.

When the placeholders are created by EdenFS when invalidating directories we
have to pass GUID. The documentation isn't clear about whether that GUID needs
to be identical to the mount point GUID, but for a very long time these have
been mismatching due to the mount point GUID being generated at startup time
and not re-used.

One of the most common issue that users have reported is that sometimes
operations on the repository start failing with the error "The provider that
supports file system virtualization is temporarily unavailable". Looking at the
output of `fsutil reparsepoint query` for all the directories from the file
that triggers the error to the root of the repositories, shows that one of the
folder and its descendant don't share the same GUID, removing it solves the
issue.

It's not clear to me why this issue doesn't always reproduce when restarting
EdenFS, but a simple step that we can take to solve this is to always re-use
the GUID, and that hopefully will lead to the GUID always being the same and
the error to go away.

Reviewed By: fanzeyi

Differential Revision: D25513122

fbshipit-source-id: 0058dedbd7fd8ccae1c9527612ac220bc6775c69
2020-12-15 08:07:49 -08:00
..
CMakeLists.txt move strace logging into FuseChannel 2020-10-20 09:34:03 -07:00
Dispatcher.cpp prjfs: add TARGETS file 2020-09-23 09:43:35 -07:00
Dispatcher.h Back out "prjfs: handle concurrent file/directory removal" 2020-12-10 07:42:38 -08:00
Enumerator.cpp prjfs: make readdir asynchronous 2020-11-13 14:27:26 -08:00
Enumerator.h prjfs: make readdir asynchronous 2020-11-13 14:27:26 -08:00
PrjfsChannel.cpp win: re-use guid for the lifetime of the checkout 2020-12-15 08:07:49 -08:00
PrjfsChannel.h win: re-use guid for the lifetime of the checkout 2020-12-15 08:07:49 -08:00
PrjfsRequestContext.h prjfs: thread notifications in PrjfsChannel 2020-12-03 10:45:30 -08:00