mirror of
https://github.com/facebook/sapling.git
synced 2024-10-07 23:38:50 +03:00
3b9a0310a1
Summary: If TreeInode::startLoadingInode() is in progress, and EdenServer::startTakeoverShutdown() is called, edenfs can deadlock: 1. Thread A: A FUSE request calls TreeInode::readdir() -> TreeInode::prefetch() -> TreeInode::startLoadingInode() on the children TreeInode-s -> RocksDbLocalStore::getFuture(). 2. Thread B: A takeover request calls EdenServer::performTakeoverShutdown() -> InodeMap::shutdown(). 3. Thread C: RocksDbLocalStore::getFuture() (called in step 1) completes -> TreeInode::inodeLoadComplete(). (The inodeLoadComplete continuation was registered by TreeInode::registerInodeLoadComplete().) 4. Thread C: After TreeInode::inodeLoadComplete() returns, the TreeInode's InodePtr is destructed, dropping the reference count to 0. 5. Thread C: InodeMap::onInodeUnreferenced() -> InodeMap::shutdownComplete() -> EdenMount::shutdown() (called in step 2) completes -> EdenServer::performTakeoverShutdown(). 6. Thread C: EdenServer::performTakeoverShutdown() -> localStore_.reset() -> RocksDbLocalStore::~RocksDbLocalStore(). 7. Thread C: RocksDbLocalStore::~RocksDbLocalStore() signals the thread pool to exit and waits for the pool's threads to exit. Because thread C is one of the threads managed by RocksDbLocalStore's thread pool, the signal is never handled and RocksDbLocalStore::~RocksDbLocalStore() never finishes. Fix this deadlock by executing EdenServer::shutdown()'s callback (in EdenServer::performTakeoverShutdown()) on a different thread. Reviewed By: simpkins Differential Revision: D14337058 fbshipit-source-id: 1d63b4e7d8f5103a2dde31e329150bf763be3db7 |
||
|---|---|---|
| .. | ||
| git | ||
| hg | ||
| mononoke | ||
| test | ||
| BackingStore.h | ||
| BlobAccess.cpp | ||
| BlobAccess.h | ||
| BlobCache.cpp | ||
| BlobCache.h | ||
| BlobMetadata.h | ||
| CMakeLists.txt | ||
| Diff.cpp | ||
| Diff.h | ||
| EmptyBackingStore.cpp | ||
| EmptyBackingStore.h | ||
| IObjectStore.h | ||
| LocalStore.cpp | ||
| LocalStore.h | ||
| MemoryLocalStore.cpp | ||
| MemoryLocalStore.h | ||
| ObjectStore.cpp | ||
| ObjectStore.h | ||
| RocksDbLocalStore.cpp | ||
| RocksDbLocalStore.h | ||
| SerializedBlobMetadata.cpp | ||
| SerializedBlobMetadata.h | ||
| SqliteLocalStore.cpp | ||
| SqliteLocalStore.h | ||
| StoreResult.cpp | ||
| StoreResult.h | ||