mirror of
https://github.com/facebook/sapling.git
synced 2024-10-04 22:07:44 +03:00
3bc7f9e3cc
Summary: Fix compatibility issue with Mononoke for fetching tree's metadata (S412931). We would like to resume returning the sha256 hash and content id hash for some period of time due to incompatibility issue client side. The old logic contained a problematic unti-pattern with "unwrap()" calls on option types while converting FileMetadata to FileAuxData, causing a need to support "assumptions" compatibility on top of backwards compatibility within binary edenapi transport/protocol that we already have. The diff will accommodate this remaining layer of compatibility by adding the fields back. server side was: ``` size: Some(metadata.total_size), content_sha1: Some(metadata.sha1.into()), content_blake3: Some(metadata.seeded_blake3.into()), content_id: Some(metadata.content_id.into()), content_sha256: Some(metadata.sha256.into()), ``` client side was: ``` size.unwrap() content_sha1.unwrap() content_blake3.unwrap() content_id.unwrap() content_sha256.unwrap() ``` Reviewed By: gustavoavena Differential Revision: D56567319 fbshipit-source-id: c0260c6dfeb95f5175715a9c411c5f503c5123c6 |
||
|---|---|---|
| .. | ||
| contrib | ||
| fs | ||
| integration | ||
| locale | ||
| mononoke | ||
| scm | ||
| test_support | ||
| test-data | ||
| .clang-tidy | ||
| .gitignore | ||
| .mononoke_test_file | ||
| BUILD_MODE.bzl | ||
| defs.bzl | ||
| Eden.project.toml | ||
| TARGETS | ||