mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 01:07:15 +03:00
3fdcdad190
Summary: Proxygen no longer uses `fbcode_builder` to run its tests, so whatever the purpose of D17158685, these `fbcode_builder` configs no longer affect Proxygen, and can be reverted to their original state. Since the general design pattern for `fbcode_builder` has been to link everything as `.so`s, let's return to this (which helps fix Bistro's build). Also, let's not waste time building & linking tests for libraries that are not the library under test. That is: - Before: The Bistro build also builds tests for wangle, proxygen, etc. This is a result of some accidental changes in D17158685. - After: We explicitly don't build test for any of the 4 dependencies here. This is OK because each project also has its own `fbcode_builder_config.py`, which **does** build tests. This latter part should result in a build-time reduction. Reviewed By: lnicco Differential Revision: D17819858 fbshipit-source-id: 7cad1bed86b2f0c3934b0fc5d6fb33e6a2ee2695
31 lines
984 B
Python
31 lines
984 B
Python
#!/usr/bin/env python
|
|
# Copyright (c) Facebook, Inc. and its affiliates.
|
|
from __future__ import absolute_import
|
|
from __future__ import division
|
|
from __future__ import print_function
|
|
from __future__ import unicode_literals
|
|
|
|
import specs.folly as folly
|
|
import specs.fizz as fizz
|
|
import specs.mvfst as mvfst
|
|
import specs.sodium as sodium
|
|
import specs.wangle as wangle
|
|
import specs.zstd as zstd
|
|
|
|
# DO NOT USE THIS AS A LIBRARY -- this is currently effectively just part
|
|
# ofthe implementation of proxygen's `fbcode_builder_config.py`. This is
|
|
# why this builds tests and sets `BUILD_QUIC`.
|
|
def fbcode_builder_spec(builder):
|
|
builder.add_option(
|
|
"proxygen/proxygen:cmake_defines",
|
|
{
|
|
"BUILD_QUIC": "ON",
|
|
"BUILD_SHARED_LIBS": "OFF",
|
|
"BUILD_TESTS": "ON",
|
|
},
|
|
)
|
|
return {
|
|
"depends_on": [folly, wangle, fizz, sodium, zstd, mvfst],
|
|
"steps": [builder.fb_github_cmake_install("proxygen/proxygen", "..")],
|
|
}
|