mirror of
https://github.com/facebook/sapling.git
synced 2024-10-12 09:48:05 +03:00
41e75fce3f
Summary: quark-zju noticed in code review that `Cursor` could get into an infinite loop when it's results would be collected into a Vec<_>. That was the motive that I needed to update `Cursor` to transition to `State::Done` when the cursor encounters an error. Previously I felt that users of `Cursor` would only be empowered by having the ability to retry the failure. Reviewed By: quark-zju Differential Revision: D14393590 fbshipit-source-id: b3e0974ac15d62f3f17790229121c0dec3a6149e |
||
---|---|---|
.. | ||
argparse | ||
asyncpacks/src | ||
bookmarkstore | ||
cdatapack | ||
clib | ||
commitcloudsubscriber | ||
configparser | ||
cpython-ext | ||
cpython-failure | ||
edenapi | ||
encoding | ||
hg_watchman_client | ||
hgpython | ||
indexedlog | ||
linelog | ||
lz4-pyframe | ||
manifest | ||
minibench | ||
mpatch | ||
mpatch-sys | ||
mutationstore | ||
nodemap | ||
pathmatcher | ||
radixbuf | ||
revisionstore | ||
third-party | ||
treestate | ||
types | ||
url-ext | ||
vlqencoding | ||
watchman_client | ||
zstdelta | ||
Cargo.toml | ||
README.md |
lib
Any native code (C/C++/Rust) that Mercurial (either core or extensions)
depends on should go here. Python code, or native code that depends on
Python code (e.g. #include <Python.h>
or use cpython
) is disallowed.
As we start to convert more of Mercurial into Rust, and write new paths entrirely in native code, we'll want to limit our dependency on Python, which is why this barrier exists.
See also hgext/extlib/README.md
, mercurial/cext/README.mb
.
How do I choose between lib
and extlib
(and cext
)?
If your code is native and doesn't depend on Python (awesome!), it goes here.
Otherwise, put it in hgext/extlib
(if it's only used by extensions) or
mercurial/cext
(if it's used by extensions or core).