mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 17:27:53 +03:00
584656dff3
Summary: Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`. Then run `arc lint` again so some other autofixers like spellchecker etc. looked at the code base. Manually accept the changes whenever they make sense, or use a workaround (ex. changing "dict()" to "dict constructor") where autofix is false positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less interesting to fix (hgsubversion tests), or cannot be fixed without breaking OSS build (FBPYTHON4). Conflicted linters (test-check-module-imports.t, part of test-check-code.t, test-check-pyflakes.t) are removed or disabled. Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed. An issue of the auto-formatter is lines are no longer guarnateed to be <= 80 chars. But that seems less important comparing with the benefit auto-formatter provides. As we're here, also remove test-check-py3-compat.t, as it is currently broken if `PYTHON3=/bin/python3` is set. Reviewed By: wez, phillco, simpkins, pkaush, singhsrb Differential Revision: D8173629 fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
79 lines
2.3 KiB
Python
79 lines
2.3 KiB
Python
# commitextras.py
|
|
#
|
|
# Copyright 2013 Facebook, Inc.
|
|
#
|
|
# This software may be used and distributed according to the terms of the
|
|
# GNU General Public License version 2 or any later version.
|
|
|
|
"""adds a new flag extras to commit (ADVANCED)"""
|
|
|
|
from __future__ import absolute_import
|
|
|
|
import re
|
|
|
|
from mercurial import commands, error, extensions, registrar
|
|
from mercurial.i18n import _
|
|
|
|
|
|
cmdtable = {}
|
|
command = registrar.command(cmdtable)
|
|
testedwith = "ships-with-hg-core"
|
|
|
|
usedinternally = {
|
|
"amend_source",
|
|
"branch",
|
|
"close",
|
|
"histedit_source",
|
|
"topic",
|
|
"rebase_source",
|
|
"intermediate-source",
|
|
"__touch-noise__",
|
|
"source",
|
|
"transplant_source",
|
|
}
|
|
|
|
|
|
def extsetup(ui):
|
|
entry = extensions.wrapcommand(commands.table, "commit", _commit)
|
|
options = entry[1]
|
|
options.append(
|
|
("", "extra", [], _("set a changeset's extra values"), _("KEY=VALUE"))
|
|
)
|
|
|
|
|
|
def _commit(orig, ui, repo, *pats, **opts):
|
|
origcommit = repo.commit
|
|
try:
|
|
|
|
def _wrappedcommit(*innerpats, **inneropts):
|
|
extras = opts.get(r"extra")
|
|
if extras:
|
|
for raw in extras:
|
|
if "=" not in raw:
|
|
msg = _(
|
|
"unable to parse '%s', should follow " "KEY=VALUE format"
|
|
)
|
|
raise error.Abort(msg % raw)
|
|
k, v = raw.split("=", 1)
|
|
if not k:
|
|
msg = _("unable to parse '%s', keys can't be empty")
|
|
raise error.Abort(msg % raw)
|
|
if re.search("[^\w-]", k):
|
|
msg = _(
|
|
"keys can only contain ascii letters, digits,"
|
|
" '_' and '-'"
|
|
)
|
|
raise error.Abort(msg)
|
|
if k in usedinternally:
|
|
msg = _("key '%s' is used internally, can't be set " "manually")
|
|
raise error.Abort(msg % k)
|
|
inneropts[r"extra"][k] = v
|
|
return origcommit(*innerpats, **inneropts)
|
|
|
|
# This __dict__ logic is needed because the normal
|
|
# extension.wrapfunction doesn't seem to work.
|
|
repo.__dict__["commit"] = _wrappedcommit
|
|
return orig(ui, repo, *pats, **opts)
|
|
finally:
|
|
del repo.__dict__["commit"]
|