mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 08:47:12 +03:00
0e80806e94
Variables that are used or assigned without any declaration using var (or let, or const) are considered global. In many cases this is inadvertent and actually causes a variable leaking to a broader scope, such as a temporary variable used inside a loop suddenly being accessible in global scope. (This corresponds to "undef" option of jshint). So this patch limits the scope of variables that don't need to be global. There are a lot of helper variables in Graph.render() used in a loop, I've declared them all on one line to reduce patch size. "radius" is special because it wasn't passed to graph.vertex, but was used there (it worked because this variable leaked to global scope). "window.graph" is created by an inline script in graph.tmpl so that it can be used in ajaxScrollInit() function, this patch makes this fact explicit by assigning window.graph to a local variable. |
||
|---|---|---|
| .. | ||
| bookmarks.tmpl | ||
| branches.tmpl | ||
| changelog.tmpl | ||
| changelogentry.tmpl | ||
| changeset.tmpl | ||
| error.tmpl | ||
| fileannotate.tmpl | ||
| filecomparison.tmpl | ||
| filediff.tmpl | ||
| filelog.tmpl | ||
| filerevision.tmpl | ||
| footer.tmpl | ||
| graph.tmpl | ||
| header.tmpl | ||
| help.tmpl | ||
| helptopics.tmpl | ||
| index.tmpl | ||
| manifest.tmpl | ||
| map | ||
| notfound.tmpl | ||
| search.tmpl | ||
| shortlog.tmpl | ||
| summary.tmpl | ||
| tags.tmpl | ||