mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 09:17:30 +03:00
7f8aae31f9
Summary: We are seeing random segment fault originating from OpenSSL on macOS when Mononoke fetching is enabled. The cause is that on macOS we are actually linking against libcurl shipped with the system instead of ours. That copy of libcurl is linked with macOS's libcrypto instead of the one we compiles during Eden's build, and it seems that version of libcrypto does not provide concurrency safety. The solution is to build curl on macOS and make sure it is linked to our OpenSSL that has the concurrency callbacks registered. Reviewed By: wez Differential Revision: D17657822 fbshipit-source-id: 85abdf3be10b3903a5efc6b3a91624c7258de790
33 lines
852 B
Plaintext
33 lines
852 B
Plaintext
[manifest]
|
|
name = libcurl
|
|
|
|
[download]
|
|
url = https://curl.haxx.se/download/curl-7.65.1.tar.gz
|
|
sha256 = 821aeb78421375f70e55381c9ad2474bf279fc454b791b7e95fc83562951c690
|
|
|
|
[dependencies]
|
|
nghttp2
|
|
|
|
# We use system OpenSSL on Linux (see folly's manifest for details)
|
|
[dependencies.not(os=linux)]
|
|
openssl
|
|
|
|
[build.not(os=windows)]
|
|
builder = autoconf
|
|
subdir = curl-7.65.1
|
|
|
|
[autoconf.args]
|
|
# fboss (which added the libcurl dep) doesn't need ldap so it is disabled here.
|
|
# if someone in the future wants to add ldap for something else, it won't hurt
|
|
# fboss. However, that would require adding an ldap manifest.
|
|
#
|
|
# For the same reason, we disable libssh2 and libidn2 which aren't really used
|
|
# but would require adding manifests if we don't disable them.
|
|
--disable-ldap
|
|
--without-libssh2
|
|
--without-libidn2
|
|
|
|
[build.os=windows]
|
|
builder = cmake
|
|
subdir = curl-7.65.1
|