mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 00:14:35 +03:00
fb5fdb9c15
Summary: Remove the `repo_id` parameter from the `Bookmarks` trait methods. The `repo_id` parameters was intended to allow a single `Bookmarks` implementation to serve multiple repos. In practise, however, each repo has its own config, which results in a separate `Bookmarks` instance for each repo. The `repo_id` parameter complicates the API and provides no benefit. To make this work, we switch to the `Builder` pattern for `SqlBookmarks`, which allows us to inject the `repo_id` at construction time. In fact nothing here prevents us from adding back-end sharing later on, as these `SqlBookmarks` objects are free to share data in their implementation. Reviewed By: StanislavGlebik Differential Revision: D22437089 fbshipit-source-id: d20e08ce6313108b74912683c620d25d6bf7ca01 |
||
|---|---|---|
| .. | ||
| blobrepo_hg | ||
| blobsync | ||
| changeset_fetcher | ||
| errors | ||
| factory | ||
| override | ||
| repo_blobstore | ||
| src | ||
| test | ||
| Cargo.toml | ||