Thomas Orozco db4c509b9e mononoke: use MononokeEnvironment in RepoFactory ... Summary: There is a very frustrating operation that happens often when working on the Mononoke code base: - You want to add a flag - You want to consume it in the repo somewhere Unfortunately, when we need to do this, we end up having to thread this from a million places and parse it out in every single main() we have. This is a mess, and it results in every single Mononoke binary starting with heaps of useless boilerplate: ``` let matches = app.get_matches(); let (caching, logger, mut runtime) = matches.init_mononoke(fb)?; let config_store = args::init_config_store(fb, &logger, &matches)?; let mysql_options = args::parse_mysql_options(&matches); let blobstore_options = args::parse_blobstore_options(&matches)?; let readonly_storage = args::parse_readonly_storage(&matches); ``` So, this diff updates us to just use MononokeEnvironment directly in RepoFactory, which means none of that has to happen: we can now add a flag, parse it into MononokeEnvironment, and get going. While we're at it, we can also remove blobstore options and all that jazz from MononokeApiEnvironment since now it's there in the underlying RepoFactory. Reviewed By: HarveyHunt Differential Revision: D27767700 fbshipit-source-id: e1e359bf403b4d3d7b36e5f670aa1a7dd4f1d209		2021-04-16 10:27:43 -07:00
..
src	mononoke: use MononokeEnvironment in RepoFactory	2021-04-16 10:27:43 -07:00
Cargo.toml	mononoke_api: use RepoFactory to construct repositories	2021-04-07 14:01:47 -07:00