mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 01:07:15 +03:00
49acaf17b3
Summary: The diffhelpers.c lacks of type checks and segfaults on Python 3: (gdb) r --config patch.eol=auto import -d '0 0' -m 'test patch.eol' --bypass ../test.diff --debug --traceback Program received signal SIGSEGV, Segmentation fault. 0x00007ffff7263016 in __strcmp_sse42 () from /lib64/libc.so.6 (gdb) bt #0 0x00007ffff7263016 in __strcmp_sse42 () from /lib64/libc.so.6 #1 0x00007fffee5e3d3b in testhunk (self=<optimized out>, args=<optimized out>) at edenscm/mercurial/cext/diffhelpers.c:151 Looking at the diffhelpers usage, it seems to be using the `bytes` type (bytes on Python 2, str on Python 3). Let's implement it in Rust so `rust-cpython` will complain if the type is not `bytes`. Reviewed By: xavierd Differential Revision: D20935366 fbshipit-source-id: 8b474555b52caeab4175d7dad44c4c4e7097e557 |
||
|---|---|---|
| .. | ||
| benchmarks | ||
| docs | ||
| fs | ||
| integration | ||
| locale | ||
| mononoke | ||
| scm | ||
| scripts | ||
| test_support | ||
| test-data | ||
| third-party | ||
| win | ||
| .gitignore | ||
| Eden.project.toml | ||