sapling/bookmarks
Jeremy Fitzhardinge ac31713c84 rust: failure cleanup pass
Summary:
Don't use failure's bail!() and ensure!() macros.

Instead, failure_ext provides:
- bail_err!(err) - Converts its single parameter to the expected error and returns; ie `return Err(From::from(err));`
- bail_msg!(fmt, ...) - takes format string parameters and returns a `failure::err_msg()` error
- ensure_err!(), ensure_msg!() - corresponding changes

Also:
- remove all stray references to error-chain
- remove direct references to failure_derive (it's reexported via failure and failure_ext)
- replace uses of `Err(foo)?;` with `bail_err!()` (since `bail_err` unconditionally returns, but `Err(x)?` does not in principle, which can affect type inference)

Reviewed By: kulshrax

Differential Revision: D6507717

fbshipit-source-id: 635fb6f8c96d185b195dff171ea9c8db9e83af10
2017-12-07 14:10:17 -08:00
..
dbbookmarks/src rust: mass convert scm/mononoke/... to use failure 2017-12-05 18:11:13 -08:00
filebookmarks/src rust: mass convert scm/mononoke/... to use failure 2017-12-05 18:11:13 -08:00
membookmarks/src rust: mass convert scm/mononoke/... to use failure 2017-12-05 18:11:13 -08:00
src rust: mass convert scm/mononoke/... to use failure 2017-12-05 18:11:13 -08:00
stockbookmarks/src rust: failure cleanup pass 2017-12-07 14:10:17 -08:00
test Make Bookmarks a parameterless trait 2017-11-27 08:05:02 -08:00