mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
4e7af724fb
Summary: On Windows, `pathlib.Path.resolve` has an use of uninitialized memory bug in Python 3.6.2. Lego Windows has this version of Python 3 installed. When `eden prefetch` runs, it will first attempt to read the config file at the root of the repository (`$REPOROOT/.eden/config`). Because of this bug, when we normalize the path in edenfsctl, it will get some random bytes as a result. This subsequently causes `toml.read` to fail as it is unable to read a path containing NUL byte. As you can see, this is the same exception as we see on Windows: ``` In [1]: open("test\x00") --------------------------------------------------------------------------- ValueError Traceback (most recent call last) <ipython-input-1-57764b20d660> in <module> ----> 1 open("test\x00") ValueError: embedded null byte ``` Reviewed By: xavierd Differential Revision: D22177997 fbshipit-source-id: ab2565c8946d809bc15bc1597b749fb5e9440ca0 |
||
---|---|---|
.. | ||
fs | ||
integration | ||
locale | ||
mononoke | ||
scm | ||
scripts | ||
test_support | ||
test-data | ||
win | ||
.clang-format | ||
.gitignore | ||
Eden.project.toml |