mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 08:18:15 +03:00
aa8152f1dd
Summary:
The use of dyn traits of the Thrift-generated server traits was emitting future compatibility warnings with recent versions of rustc, due to a fixed soundness hole in the trait object system:
```
error: the trait `x_account_aggregator_if::server::XAccountAggregator` cannot be made into an object
|
= this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
note: for a trait to be "object safe" it needs to allow building a vtable to allow the call to be resolvable dynamically; for more information visit <https://doc.rust-lang.org/reference/items/traits.html#object-safety>
```
This diff pulls in https://github.com/dtolnay/async-trait/releases/tag/0.1.51 which results in the Thrift-generated server traits no longer hitting the problematic pattern.
Reviewed By: zertosh
Differential Revision: D29979939
fbshipit-source-id: 3e6e976181bfcf35ed453ae681baeb76a634ddda
|
||
|---|---|---|
| .. | ||
| blobstore_stats | ||
| cacheblob | ||
| chaosblob | ||
| delayblob | ||
| ephemeral_blobstore | ||
| factory | ||
| fileblob | ||
| if | ||
| logblob | ||
| memblob | ||
| multiplexedblob | ||
| packblob | ||
| prefixblob | ||
| readonlyblob | ||
| redactedblobstore | ||
| samplingblob | ||
| sqlblob | ||
| src | ||
| test | ||
| throttledblob | ||
| virtually_sharded_blobstore | ||
| Cargo.toml | ||