mirror of
https://github.com/facebook/sapling.git
synced 2024-10-12 17:58:27 +03:00
5a10c5fbf9
Summary: Instantiating a new DB connection may require remote calls to be made to e.g. Hipster to allocate a new certificate (this is only the case when connecting to MySQL). Currently, our bindings to our underlying DB locator make a blocking call to pretend that this operaiton is synchronous: https://fburl.com/ytmljxkb This isn't ideal, because this call might actually take time, and we might also occasionally want to retry it (we've had issues in our MySQL tests with acquiring certificates that retrying should resolve). Running this synchronously makes doing so inefficient. This patch doesn't update that, but it fixes everything on the Rust side of things to stop expecting connections to return a `Result` (and to start expecting a Future instead). In a follow up diff, I'll work on making the changes in common/rust/sql to start returning a Future here. Reviewed By: StanislavGlebik Differential Revision: D16221857 fbshipit-source-id: 263f9237ff9394477c65e455de91b19a9de24a20 |
||
|---|---|---|
| .. | ||
| blob_changeset/src | ||
| changeset_fetcher/src | ||
| errors/src | ||
| factory/src | ||
| repo_blobstore/src | ||
| src | ||
| test | ||
| Cargo.toml | ||