sapling/eden/mononoke/segmented_changelog
Stefan Filip 65054f2044 segmented_changelog: add comments around IdMap insert expectations
Summary:
Comments for why we don't need a lock when updating the SqlIdMap with multiple
writers. Structure can definitely be improved but I'll live with this for a
short time.

No fundamental change in logic. I added extra checks to the insert function and
changed from an optimistic insert race logic to a pessimistic version. I
explain in the comments that it's to have an easier time reasoning about what
happens and that theoretically doesn't matter.

Reviewed By: quark-zju

Differential Revision: D25606290

fbshipit-source-id: ea21915fc797fe759b3fe481e8ad9e8cb594fb6a
2020-12-23 16:51:08 -08:00
..
schemas segmented_changelog: update iddag store key to blake2 2020-10-29 17:40:18 -07:00
src segmented_changelog: add comments around IdMap insert expectations 2020-12-23 16:51:08 -08:00
Cargo.toml segmented_changelog: add SegmentedChangelog::full_idmap_clone_data 2020-12-08 18:30:24 -08:00