Stefan Filip 02606da6c5 pathmatcher: allow errors in match function definition ... Summary: The most common scenario where we see matcher errors is when we iterate through a manifest and the user sends SIGTERM to the process. The matcher may be both Rust and Python code. The Python code handles the interrupt and prevents future function calls. The iterating Rust code will continue to call matcher functions through this time so we get matcher errors from the terminated Python stack. As long as we have Python matcher code, errors are valid. It is unclear to me whether the matcher trait should have `Result` return values when all implementations are Rust. It is easy to imagine implementations that can fail in different circumstances but the ones that we use if we just port the Python code wouldn't fail. All in all, I think that this is a reasonable step forward. Reviewed By: quark-zju Differential Revision: D25697099 fbshipit-source-id: f61c80bd0a8caa58040a447ed02d48a1ae84ad60		2021-01-07 16:22:17 -08:00
..
src	pathmatcher: allow errors in match function definition	2021-01-07 16:22:17 -08:00
Cargo.toml	pathmatcher: allow errors in match function definition	2021-01-07 16:22:17 -08:00