mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 00:14:35 +03:00
692cfc05a8
(makes issue2135, issue2264 more obvious, but does nothing to fix
either one)
This seems to happen in two distinct cases:
* patch.patch() claims success but changes nothing (e.g.
the transplanted changeset adds an empty file that already
exists)
* patch.patch() makes changes, but repo.status() fails to report them
Both of these seem like bugs in other parts of Mercurial, so arguably
it's not transplant's job to detect the failure to commit. However:
* detecting the problem as soon as possible is desirable
* it prevents a more obscure crash later, in transplants.write()
* there might be other lurking (or future) bugs that cause
repo.commit() to do nothing
Also, in the case of issue2264 (source changesets silently dropped by
transplant), the only way to spot the problem currently is the crash
in transplants.write(). Failure to transplant a patch should abort
immediately, whether it's user error (patch does not apply) or a
Mercurial bug (e.g. repo.status() failing to report changes).
|
||
|---|---|---|
| .. | ||
| convert | ||
| highlight | ||
| inotify | ||
| zeroconf | ||
| __init__.py | ||
| acl.py | ||
| bookmarks.py | ||
| bugzilla.py | ||
| children.py | ||
| churn.py | ||
| color.py | ||
| eol.py | ||
| extdiff.py | ||
| fetch.py | ||
| gpg.py | ||
| graphlog.py | ||
| hgcia.py | ||
| hgk.py | ||
| interhg.py | ||
| keyword.py | ||
| mq.py | ||
| notify.py | ||
| pager.py | ||
| parentrevspec.py | ||
| patchbomb.py | ||
| progress.py | ||
| purge.py | ||
| rebase.py | ||
| record.py | ||
| relink.py | ||
| schemes.py | ||
| share.py | ||
| transplant.py | ||
| win32mbcs.py | ||
| win32text.py | ||