mirror of
https://github.com/facebook/sapling.git
synced 2024-10-07 15:27:13 +03:00
9dc21f8d0b
Summary: D13853115 adds `edenscm/` to `sys.path` and code still uses `import mercurial`. That has nasty problems if both `import mercurial` and `import edenscm.mercurial` are used, because Python would think `mercurial.foo` and `edenscm.mercurial.foo` are different modules so code like `try: ... except mercurial.error.Foo: ...`, or `isinstance(x, mercurial.foo.Bar)` would fail to handle the `edenscm.mercurial` version. There are also some module-level states (ex. `extensions._extensions`) that would cause trouble if they have multiple versions in a single process. Change imports to use the `edenscm` so ideally the `mercurial` is no longer imported at all. Add checks in extensions.py to catch unexpected extensions importing modules from the old (wrong) locations when running tests. Reviewed By: phillco Differential Revision: D13868981 fbshipit-source-id: f4e2513766957fd81d85407994f7521a08e4de48
41 lines
1.1 KiB
Python
41 lines
1.1 KiB
Python
# Copyright 2017 Facebook, Inc.
|
|
#
|
|
# This software may be used and distributed according to the terms of the
|
|
# GNU General Public License version 2 or any later version.
|
|
|
|
import string
|
|
|
|
from edenscm.mercurial.i18n import _
|
|
|
|
|
|
def reposetup(ui, repo):
|
|
ui.setconfig("hooks", "pretxncommit.checkmessage", checkcommitmessage)
|
|
|
|
|
|
def checkcommitmessage(ui, repo, **kwargs):
|
|
"""
|
|
Checks a single commit message for adherence to commit message rules.
|
|
"""
|
|
hg_commit_message = repo["tip"].description()
|
|
try:
|
|
hg_commit_message.decode("utf8")
|
|
except UnicodeDecodeError:
|
|
ui.warn(_("commit message is not utf-8\n"))
|
|
return True
|
|
|
|
printable = set(string.printable)
|
|
badlines = []
|
|
for lnum, line in enumerate(hg_commit_message.splitlines()):
|
|
for c in line:
|
|
if ord(c) < 128 and c not in printable:
|
|
badlines.append((lnum + 1, line))
|
|
break
|
|
|
|
if badlines:
|
|
ui.warn(_("non-printable characters in commit message\n"))
|
|
for num, l in badlines:
|
|
ui.warn(_("Line {}: {!r}\n".format(num, l)))
|
|
|
|
# False means success
|
|
return bool(badlines)
|