mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
fb45633a19
Summary: Python loads .so using mmap. Rewriting a .so in-place when there is a Python process with that .so mmap-ed could crash that Python process. Therefore let's avoid rewriting the destination .so in-place. This was discovered by a txnclose Python hook I used to keep binaries up-to-date. It caused segfault after building the Rust extensions currently loaded by the Python process running the hook. Test Plan: `hg push` triggering that txnclose hook won't crash on the remote. Reviewers: durham, #sourcecontrol Reviewed By: durham Differential Revision: https://phabricator.intern.facebook.com/D6686739 Signature: 6686739:1515532516:24c0b7066ff15a39a7bd824e779569f4a886d7df |
||
---|---|---|
.. | ||
__init__.py |