mirror of
https://github.com/facebook/sapling.git
synced 2024-10-07 07:17:55 +03:00
c363f01ef4
Before this patch, we don't have a safe way to undo a wrapfunction because other extensions may wrap the same function and calling setattr will undo them accidentally. This patch adds an "unwrapfunction" to address the issue. It removes the wrapper from the wrapper chain, and re-wraps everything, which is not the most efficient but short and easy to understand. We can revisit the code if we have perf issues with long chains. The "undo" feature is useful in cases like wrapping a function just in a scope. Like, having a "select" command to interactively (using arrow keys) select content from some output (ex. smartlog). It could wrap "ui.label" to extract interesting texts just in the "select" command.
15 lines
390 B
Plaintext
15 lines
390 B
Plaintext
wrap 0: [0, 'orig']
|
|
wrap 1: [1, 0, 'orig']
|
|
wrap 2: [2, 1, 0, 'orig']
|
|
wrap 3: [3, 2, 1, 0, 'orig']
|
|
wrap 4: [4, 3, 2, 1, 0, 'orig']
|
|
wrap 0: [0, 4, 3, 2, 1, 0, 'orig']
|
|
unwrap 3: 3: [0, 4, 2, 1, 0, 'orig']
|
|
unwrap -: 0: [4, 2, 1, 0, 'orig']
|
|
unwrap 0: 0: [4, 2, 1, 'orig']
|
|
unwrap 4: 4: [2, 1, 'orig']
|
|
unwrap 0: -: ValueError
|
|
unwrap 2: 2: [1, 'orig']
|
|
unwrap 1: 1: ['orig']
|
|
unwrap -: -: IndexError
|