mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 09:17:30 +03:00
74b47b28da
Summary: Sometimes, our Mononoke CLI tests report errors in mode/opt where they don't actually output error messages at all when returning an error. Those error messages actually get buffered by our logger, and are normally emitted when said logger is dropped. However, I have a suspicion that by calling process::exit(), we're not giving Rust a chance to drop the logger (because that eventually just calls the exit syscall), and as a result our buffer isn't getting flushed. This patch attempts to fix this by removing all calls to process::exit in the admin CLI, and instead returning an exit code from main, which I hope will allow main to drop everything before it returns. More broadly speaking, I don't think it's very good practice to exit from all over the place in the admin CLI, so this fixes that :) Reviewed By: HarveyHunt Differential Revision: D16687747 fbshipit-source-id: 38e987463363e239d4f9166050a8dd26a4bef985 |
||
|---|---|---|
| .. | ||
| blacklist.rs | ||
| blobstore_fetch.rs | ||
| bonsai_fetch.rs | ||
| bookmarks_manager.rs | ||
| cmdargs.rs | ||
| common.rs | ||
| content_fetch.rs | ||
| error.rs | ||
| filenodes.rs | ||
| filestore.rs | ||
| hash_convert.rs | ||
| hg_changeset.rs | ||
| hg_sync.rs | ||
| main.rs | ||
| public_phases.rs | ||
| skiplist_subcommand.rs | ||