mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 00:45:18 +03:00
89f77ed920
BTW, C implementation of hexdigest() for SHA-1/256/512 returns hex hash in lower case, and doctest in Python standard hashlib assumes that, too. But it isn't explicitly described in API document or so. Therefore, we can't assume that hexdigest() always returns hex hash in lower case, for any hash algorithms, on any Python runtimes and versions. From point of view of that, it is reasonable for portability that 77f8c025a6ef applies lower() on hex hash in overridefilemerge(). But on the other hand, in largefiles extension, there are still many code paths comparing between hex hashes or storing hex hash into standin file, without lower(). Switching to hash algorithm other than SHA-1 may be good chance to clarify our policy about hexdigest()-ed hash value string. - assume that hexdigest() always returns hex hash in lower case, or - apply lower() on hex hash in appropriate layers to ensure lower-case-ness of it for portability |
||
---|---|---|
.. | ||
__init__.py | ||
basestore.py | ||
CONTRIBUTORS | ||
lfcommands.py | ||
lfutil.py | ||
localstore.py | ||
overrides.py | ||
proto.py | ||
remotestore.py | ||
reposetup.py | ||
storefactory.py | ||
uisetup.py | ||
wirestore.py |