facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 00:45:18 +03:00
Code Issues Projects Releases Wiki Activity
755a238a5d
sapling/eden/scm/edenscm/mercurial/cext
History
Jun Wu 755a238a5d osutil: remove usage of ApplicationServices 
Summary:
We recently saw a high rate of build failures on MacOS.
They all fail with compiler errors like:

    In file included from edenscm/mercurial/cext/osutil.c:1326:
    In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/ApplicationServices.framework/Headers/ApplicationServices.h:23:
    In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h:39:
    In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Headers/LaunchServices.h:23:
    In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Headers/IconsCore.h:23:
    In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/OSServices.h:29:
    In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/CSIdentity.h:43:
    In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/Security.framework/Headers/Security.h:38:
    In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/Security.framework/Headers/SecProtocolOptions.h:28:
    /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/Security.framework/Headers/SecProtocolTypes.h:158:19: error: missing ',' between enumerators
        kTLSProtocol12 CF_ENUM_DEPRECATED(10_2, 10_15, 5_0, 13_0) = 8,
                      ^
    /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk//System/Library/Frameworks/Security.framework/Headers/SecProtocolTypes.h:158:20: error: redefinition of enumerator '__AVAILABILITY_INTERNAL__MAC_10_2_DEP__MAC_10_15'
        kTLSProtocol12 CF_ENUM_DEPRECATED(10_2, 10_15, 5_0, 13_0) = 8,
                   ^

It's unclear whether this is a compiler configuration issue, or the Apple SDK
being buggy.

The only user of ApplicationServices is `isgui()` when `$SSH_CONNECTION` is not
set on MacOS.

It seems to me that if we just replace `isgui()` to `True`, very few if nobody
will notice the difference. Therefore let's remove the problematic
ApplicationServices as an attempt to stabilize the build.

FWIW Git does not seem to have any sort of GUI detection. It seems to solely
rely on (static) user configuration.

This reverts part of https://www.mercurial-scm.org/repo/hg/rev/16118b4859a1.

Reviewed By: singhsrb

Differential Revision: D19441351

fbshipit-source-id: f1bfbaf0d015e8d577a83112b5ea0a4be6367156
2020-01-17 07:25:37 -08:00
..
__init__.py Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
base85.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
bdiff.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
charencode.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
charencode.h Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
diffhelpers.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
dirs.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
manifest.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
mpatch.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
osutil.c osutil: remove usage of ApplicationServices 2020-01-17 07:25:37 -08:00
parsers.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
pathencode.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
README.md Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
revlog.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
util.h Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00
xdiff.c Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00

README.md

cext

Native code used by core Mercurial (not extensions), that depends on Python, lives here.

See also hgext/extlib/README.md, lib/README.md.