sapling/remotefilelog/ctreemanifest
Durham Goode 7639fb3427 ctree: fix ref counting for args that are put in PythonObj wrappers
Summary:
It turns out PyArg_ParseTuple doesn't create new refs, so if we put any
arguments in PythonObj wrappers, they will be incorrectly decremented during
destruction. Let's increment the ref before putting any args in PythonObj.

Test Plan:
N/A, I just eyeballed this. I did look at all other uses of
PyArg_ParseTuple to verify no other cases had this issue.

Reviewers: #fastmanifest

Differential Revision: https://phabricator.intern.facebook.com/D3766116
2016-08-29 16:19:52 -07:00
..
convert.h [ctree] create a new method appendbinfromhex 2016-08-26 13:49:17 -07:00
manifest_entry.cpp [ctree] initialize the ManifestEntry in addChild after adding to the list 2016-08-26 13:49:17 -07:00
manifest_entry.h ctree: move Python.h to be included first 2016-08-29 16:19:52 -07:00
manifest_fetcher.cpp [ctree] get rid of manifestkey 2016-08-22 15:42:03 -07:00
manifest_fetcher.h ctree: move Python.h to be included first 2016-08-29 16:19:52 -07:00
manifest.cpp [ctree] initialize the ManifestEntry in addChild after adding to the list 2016-08-26 13:49:17 -07:00
manifest.h ctree: move Python.h to be included first 2016-08-29 16:19:52 -07:00
py-treemanifest.cpp ctree: fix ref counting for args that are put in PythonObj wrappers 2016-08-29 16:19:52 -07:00
pythonutil.cpp ctree: implement treemanifest.matches 2016-08-29 16:19:52 -07:00
pythonutil.h ctree: implement treemanifest.matches 2016-08-29 16:19:52 -07:00
treemanifest.cpp [ctree] free memory when destroying a treemanifest object 2016-08-26 14:00:37 -07:00
treemanifest.h ctree: implement treemanifest.matches 2016-08-29 16:19:52 -07:00