mirror of
https://github.com/facebook/sapling.git
synced 2024-10-06 23:07:18 +03:00
756a483011
Before this change, asking for file from history (eg: 'hg cat -r 42 foo/bar') could fail because of the current content of the working copy (eg: current "foo" being a symlink). As the working copy state have no influence on the content of the history, we can safely skip these checks. The working copy context class have a different 'match' implementation. That implementation still use the repo.auditor will still catch symlink traversal. I've audited all stuff calling "match" and they all go through a ctx in a sensible way. The most unclear case was diff which still seemed okay. You raised my paranoid level today and I double checked through tests. They behave properly. The odds of someone using the wrong (matching with a changectx for operation that will eventually touch the file system) is non-zero because you are never sure of what people will do. But I dunno if we can fight against that. So I would not commit to "never" for "at this level" and "in the future" if someone write especially bad code. However, as a last defense, the vfs itself is running path auditor in all cases outside of .hg/. So I think anything passing the 'matcher' for buggy reason would growl at the vfs layer.
132 lines
2.5 KiB
Perl
132 lines
2.5 KiB
Perl
$ hg init
|
|
|
|
audit of .hg
|
|
|
|
$ hg add .hg/00changelog.i
|
|
abort: path contains illegal component: .hg/00changelog.i (glob)
|
|
[255]
|
|
|
|
#if symlink
|
|
|
|
Symlinks
|
|
|
|
$ mkdir a
|
|
$ echo a > a/a
|
|
$ hg ci -Ama
|
|
adding a/a
|
|
$ ln -s a b
|
|
$ echo b > a/b
|
|
$ hg add b/b
|
|
abort: path 'b/b' traverses symbolic link 'b' (glob)
|
|
[255]
|
|
$ hg add b
|
|
|
|
should still fail - maybe
|
|
|
|
$ hg add b/b
|
|
abort: path 'b/b' traverses symbolic link 'b' (glob)
|
|
[255]
|
|
|
|
$ hg commit -m 'add symlink b'
|
|
|
|
|
|
Test symlink traversing when accessing history:
|
|
-----------------------------------------------
|
|
|
|
(build a changeset where the path exists as a directory)
|
|
|
|
$ hg up 0
|
|
0 files updated, 0 files merged, 1 files removed, 0 files unresolved
|
|
$ mkdir b
|
|
$ echo c > b/a
|
|
$ hg add b/a
|
|
$ hg ci -m 'add directory b'
|
|
created new head
|
|
|
|
Test that hg cat does not do anything wrong the working copy has 'b' as directory
|
|
|
|
$ hg cat b/a
|
|
c
|
|
$ hg cat -r "desc(directory)" b/a
|
|
c
|
|
$ hg cat -r "desc(symlink)" b/a
|
|
b/a: no such file in rev bc151a1f53bd
|
|
[1]
|
|
|
|
Test that hg cat does not do anything wrong the working copy has 'b' as a symlink (issue4749)
|
|
|
|
$ hg up 'desc(symlink)'
|
|
1 files updated, 0 files merged, 1 files removed, 0 files unresolved
|
|
$ hg cat b/a
|
|
b/a: no such file in rev bc151a1f53bd
|
|
[1]
|
|
$ hg cat -r "desc(directory)" b/a
|
|
c
|
|
$ hg cat -r "desc(symlink)" b/a
|
|
b/a: no such file in rev bc151a1f53bd
|
|
[1]
|
|
|
|
#endif
|
|
|
|
|
|
unbundle tampered bundle
|
|
|
|
$ hg init target
|
|
$ cd target
|
|
$ hg unbundle "$TESTDIR/bundles/tampered.hg"
|
|
adding changesets
|
|
adding manifests
|
|
adding file changes
|
|
added 5 changesets with 6 changes to 6 files (+4 heads)
|
|
(run 'hg heads' to see heads, 'hg merge' to merge)
|
|
|
|
attack .hg/test
|
|
|
|
$ hg manifest -r0
|
|
.hg/test
|
|
$ hg update -Cr0
|
|
abort: path contains illegal component: .hg/test (glob)
|
|
[255]
|
|
|
|
attack foo/.hg/test
|
|
|
|
$ hg manifest -r1
|
|
foo/.hg/test
|
|
$ hg update -Cr1
|
|
abort: path 'foo/.hg/test' is inside nested repo 'foo' (glob)
|
|
[255]
|
|
|
|
attack back/test where back symlinks to ..
|
|
|
|
$ hg manifest -r2
|
|
back
|
|
back/test
|
|
#if symlink
|
|
$ hg update -Cr2
|
|
abort: path 'back/test' traverses symbolic link 'back'
|
|
[255]
|
|
#else
|
|
('back' will be a file and cause some other system specific error)
|
|
$ hg update -Cr2
|
|
abort: * (glob)
|
|
[255]
|
|
#endif
|
|
|
|
attack ../test
|
|
|
|
$ hg manifest -r3
|
|
../test
|
|
$ hg update -Cr3
|
|
abort: path contains illegal component: ../test (glob)
|
|
[255]
|
|
|
|
attack /tmp/test
|
|
|
|
$ hg manifest -r4
|
|
/tmp/test
|
|
$ hg update -Cr4
|
|
abort: path contains illegal component: /tmp/test (glob)
|
|
[255]
|
|
|
|
$ cd ..
|