mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
51a117577c
Summary: In order to remove struct Id hack in the next diff we need to implement Manifest trait for ManifestUnode struct. However, there's a problem: ManifestUnode::TreeId type is ManifestUnodeId which implements MononokeId trait. And all MononokeId types automatically implement Loadable<Value=Option<MononokeId>>. But Manifest trait requires TreeId that implement Loadable<Value=Self> - note that there's no Option<...>, and so ManifestUnodeId Loadable implementation doesn't match implementation required by Manifest trait. There are a few ways to fix it (see one of them in D16885043), and after some discussion we decided that the best way to proceed is to add a special error LoadableError that might be `Missing` meaning that id we are trying to fetch doesn't exist Reviewed By: aslpavel Differential Revision: D16915387 fbshipit-source-id: df57ff4a7ab4ddbff5812ce5929a742d949726af |
||
|---|---|---|
| .. | ||
| test | ||
| alias.rs | ||
| chunk.rs | ||
| errors.rs | ||
| expected_size.rs | ||
| fetch_key.rs | ||
| fetch.rs | ||
| finalize.rs | ||
| incremental_hash.rs | ||
| lib.rs | ||
| metadata.rs | ||
| multiplexer.rs | ||
| prepare.rs | ||
| rechunk.rs | ||
| spawn.rs | ||
| streamhash.rs | ||