mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 17:27:53 +03:00
763949e575
A `unfilteredpropertycache` is a kind of `propertycache` used on `localrepo` to unsure it will always be run against unfiltered repo and stored only once. As the cached value is never stored in the repoview instance, the descriptor will always be called. Before this patch such calls always result in a call to the `__get__` method of the `propertycache` on the unfiltered repo. That was recomputing a new value on every access through a repoview. We can't prevent the repoview's `unfilteredpropertycache` to get called on every access. In that case the new code makes a standard attribute access to the property. If a value is cached it will be used. The `propertycache` test file have been augmented with test about this issue.
85 lines
2.2 KiB
Plaintext
85 lines
2.2 KiB
Plaintext
|
|
=== property cache ===
|
|
|
|
calllog: []
|
|
cached value (unfiltered): NOCACHE
|
|
|
|
= first access on unfiltered, should do a call
|
|
access: 0
|
|
calllog: [0]
|
|
cached value (unfiltered): 0
|
|
|
|
= second access on unfiltered, should not do call
|
|
access 0
|
|
calllog: [0]
|
|
cached value (unfiltered): 0
|
|
|
|
= first access on "visible" view, should do a call
|
|
cached value ("visible" view): NOCACHE
|
|
access: 7
|
|
calllog: [0, 7]
|
|
cached value (unfiltered): 0
|
|
cached value ("visible" view): 7
|
|
|
|
= second access on "visible view", should not do call
|
|
access: 7
|
|
calllog: [0, 7]
|
|
cached value (unfiltered): 0
|
|
cached value ("visible" view): 7
|
|
|
|
= no effect on other view
|
|
cached value ("immutable" view): NOCACHE
|
|
access: 9
|
|
calllog: [0, 7, 9]
|
|
cached value (unfiltered): 0
|
|
cached value ("visible" view): 7
|
|
cached value ("immutable" view): 9
|
|
|
|
|
|
=== unfiltered property cache ===
|
|
|
|
unficalllog: []
|
|
cached value (unfiltered): NOCACHE
|
|
cached value ("visible" view): NOCACHE
|
|
cached value ("immutable" view): NOCACHE
|
|
|
|
= first access on unfiltered, should do a call
|
|
access (unfiltered): 100
|
|
unficalllog: [100]
|
|
cached value (unfiltered): 100
|
|
|
|
= second access on unfiltered, should not do call
|
|
access (unfiltered): 100
|
|
unficalllog: [100]
|
|
cached value (unfiltered): 100
|
|
|
|
= access on view should use the unfiltered cache
|
|
access (unfiltered): 100
|
|
access ("visible" view): 100
|
|
access ("immutable" view): 100
|
|
unficalllog: [100]
|
|
cached value (unfiltered): 100
|
|
cached value ("visible" view): NOCACHE
|
|
cached value ("immutable" view): NOCACHE
|
|
|
|
= even if we clear the unfiltered cache
|
|
cached value (unfiltered): NOCACHE
|
|
cached value ("visible" view): NOCACHE
|
|
cached value ("immutable" view): NOCACHE
|
|
unficalllog: [100]
|
|
access ("visible" view): 100
|
|
unficalllog: [100, 100]
|
|
cached value (unfiltered): 100
|
|
cached value ("visible" view): NOCACHE
|
|
cached value ("immutable" view): NOCACHE
|
|
access ("immutable" view): 100
|
|
unficalllog: [100, 100]
|
|
cached value (unfiltered): 100
|
|
cached value ("visible" view): NOCACHE
|
|
cached value ("immutable" view): NOCACHE
|
|
access (unfiltered): 100
|
|
unficalllog: [100, 100]
|
|
cached value (unfiltered): 100
|
|
cached value ("visible" view): NOCACHE
|
|
cached value ("immutable" view): NOCACHE
|