mirror of
https://github.com/facebook/sapling.git
synced 2024-10-13 02:07:31 +03:00
584656dff3
Summary: Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`. Then run `arc lint` again so some other autofixers like spellchecker etc. looked at the code base. Manually accept the changes whenever they make sense, or use a workaround (ex. changing "dict()" to "dict constructor") where autofix is false positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less interesting to fix (hgsubversion tests), or cannot be fixed without breaking OSS build (FBPYTHON4). Conflicted linters (test-check-module-imports.t, part of test-check-code.t, test-check-pyflakes.t) are removed or disabled. Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed. An issue of the auto-formatter is lines are no longer guarnateed to be <= 80 chars. But that seems less important comparing with the benefit auto-formatter provides. As we're here, also remove test-check-py3-compat.t, as it is currently broken if `PYTHON3=/bin/python3` is set. Reviewed By: wez, phillco, simpkins, pkaush, singhsrb Differential Revision: D8173629 fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
57 lines
1.5 KiB
Python
57 lines
1.5 KiB
Python
# configwarn.py - warn unsupported user configs
|
|
#
|
|
# Copyright 2017 Facebook, Inc.
|
|
#
|
|
# This software may be used and distributed according to the terms of the
|
|
# GNU General Public License version 2 or any later version.
|
|
|
|
"""warn unsupported user configs
|
|
|
|
Config::
|
|
|
|
[configwarn]
|
|
# Config names that are supposed to be set by system config and not
|
|
# overrided by user config.
|
|
systemconfigs = diff.git, extensions.hggit
|
|
"""
|
|
|
|
from __future__ import absolute_import
|
|
|
|
from mercurial import rcutil, registrar
|
|
from mercurial.i18n import _
|
|
|
|
|
|
configtable = {}
|
|
configitem = registrar.configitem(configtable)
|
|
|
|
configitem("configwarn", "systemconfigs", default=[])
|
|
|
|
|
|
def reposetup(ui, repo):
|
|
# use reposetup, not uisetup to work better with chg and it checks reporc.
|
|
if not repo.local():
|
|
return
|
|
|
|
nonsystempaths = set(rcutil.userrcpath() + [repo.vfs.join("hgrc")])
|
|
systemconfigs = ui.configlist("configwarn", "systemconfigs")
|
|
|
|
for configname in systemconfigs:
|
|
if "." not in configname:
|
|
continue
|
|
|
|
section, name = configname.split(".", 1)
|
|
source = ui.configsource(section, name)
|
|
|
|
if ":" not in source:
|
|
continue
|
|
|
|
path, lineno = source.split(":", 1)
|
|
if path in nonsystempaths and lineno.isdigit():
|
|
ui.warn(
|
|
_(
|
|
"warning: overriding config %s is unsupported (hint: "
|
|
"remove line %s from %s to resolve this issue)\n"
|
|
)
|
|
% (configname, lineno, path)
|
|
)
|