sapling/eden
Eli Lipsitz 829aee36fc physicalfilesystem: fix incorrect logic leading to duplicate path lookups
Summary:
This diff fixes some incorrect logic in the physicalfilesystem pendingchanges Rust code that leads to duplicate entries in the "lookup" list (files that need to have their contents checked to know whether they're dirty). We need to fix this, otherwise we'll do 2x the number of (potentially expensive) checks, and we'll need to deduplicate later anyway.

I believe this bug was originally introduced in D25697099 (02606da6c5) -- the change to this region of the code changes the behavior. I believe this was just an oversight when the code was refactored, since the change doesn't have anything to do with the purpose of the diff.

Reviewed By: DurhamG

Differential Revision: D34403900

fbshipit-source-id: 4c38e6a0ba46dfefc8f7ba327b943cb7ccee7fc5
2022-02-25 13:38:22 -08:00
..
fs minitop: rename TOP PID column to PID 2022-02-23 19:22:58 -08:00
hg-server Convert type comments for eden 2022-02-10 08:48:35 -08:00
integration allow building some integration test scaffolding on macOS 2022-02-25 13:32:21 -08:00
locale
mononoke Use mutable renames in the commit diff method 2022-02-25 04:19:24 -08:00
scm physicalfilesystem: fix incorrect logic leading to duplicate path lookups 2022-02-25 13:38:22 -08:00
test_support Add annotations to eden 2022-02-14 12:17:43 -08:00
test-data test-data: remove snapshot 20190313 2022-02-04 13:50:48 -08:00
.gitignore
.mononoke_test_file test push 2022-01-06 05:57:35 -08:00
Eden.project.toml