mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 01:07:15 +03:00
63b7bb19c5
Summary: Many of the template keywords in our extensions were being registered incorrectly, causing their help output to be rendered incorrectly in the "hg help templates" output. The ones in smartlog.py were particularly bad, as most of them showed only their description, without displaying the name of the template. In smartlog.py only singlepublicsuccessor was being displayed correctly, because it's docstring explicitly included it's own name at the start. This fixes all of our extensions to consistently use the registrar.templatekeyword() decorator to register the keywords. This decorator automatically prefixes the help message with the keyword name. The mercurial/extensions.py code will explicitly check to see if an extension contains an "templatekeyword" attribute, and if so it will register any keywords contained in this registry after calling extsetup(). Test Plan: Added new unit tests to check the output of "hg help templates" for the affected keywords. Reviewers: #sourcecontrol, kulshrax, ikostia, rmcelroy Reviewed By: rmcelroy Subscribers: rmcelroy, net-systems-diffs@, yogeshwer, mjpieters Differential Revision: https://phabricator.intern.facebook.com/D4427729 Signature: t1:4427729:1484831476:17b478a5e867dfc3f85402588c381bf8b1831107
41 lines
1.1 KiB
Perl
41 lines
1.1 KiB
Perl
$ PYTHONPATH=$TESTDIR/..:$PYTHONPATH
|
|
$ echo "[extensions]" >> $HGRCPATH
|
|
$ echo "phabdiff=" >> $HGRCPATH
|
|
|
|
Setup repo
|
|
|
|
$ hg init repo
|
|
$ cd repo
|
|
|
|
Test phabdiff template mapping
|
|
|
|
$ echo a > a
|
|
$ hg commit -Aqm "Differential Revision: https://phabricator.fb.com/D1234
|
|
> Task ID: 2312"
|
|
$ hg log --template "{phabdiff}\n"
|
|
D1234
|
|
|
|
$ echo c > c
|
|
$ hg commit -Aqm "Differential Revision: http://phabricator.intern.facebook.com/D1245
|
|
> Task ID: 2312"
|
|
$ hg log -r . --template "{phabdiff}\n"
|
|
D1245
|
|
|
|
$ echo b > b
|
|
$ hg commit -Aqm "Differential Revision: https://phabricator.fb.com/D5678
|
|
> Tasks:32, 44 55"
|
|
$ hg log -r . --template "{phabdiff}: {tasks}\n"
|
|
D5678: 32 44 55
|
|
|
|
$ echo d > d
|
|
$ hg commit -Aqm "Differential Revision: http://phabricator.intern.facebook.com/D1245
|
|
> Task: t123456,456"
|
|
$ hg log -r . --template "{phabdiff}: {tasks}\n"
|
|
D1245: 123456 456
|
|
|
|
Make sure the template keywords are documented correctly
|
|
|
|
$ hg help templates | egrep 'phabdiff|tasks'
|
|
phabdiff String. Return the phabricator diff id for a given hg rev.
|
|
tasks String. Return the tasks associated with given hg rev.
|