sapling/eden/scm/lib/revisionstore
Arun Kulshreshtha 8cc3939f35 revisionstore: do not swallow errors from EdenAPI stores
Summary:
Previously, the EdenAPI stores would not report errors returned from the remote store. The intention behind this pattern in other stores is to prevent `KeyError`s from aborting the operation since the local store might still have the key.

However, in the case of the EdenAPI store, EdenAPI will simply omit missing keys in its response rather than returning an error. Instead, any error returned by the EdenAPI store indicates a more fundamental problem (e.g., unable to reach the server, connection reset, etc) which should cause an abort and return the error.

Reviewed By: quark-zju

Differential Revision: D22544031

fbshipit-source-id: e01e8d88b75e46dcebd2eef5203e3a0edde69fc7
2020-07-15 15:07:51 -07:00
..
src revisionstore: do not swallow errors from EdenAPI stores 2020-07-15 15:07:51 -07:00
types eden/scm: split revisionstore into types and rest of logic 2020-04-14 07:50:19 -07:00
Cargo.toml revisionstore: add EdenApiFileStore and EdenApiTreeStore 2020-07-13 17:35:31 -07:00
CMakeLists.txt Merge fb-mercurial sources into the eden repository 2019-11-13 20:20:32 -08:00
RevisionStore.cpp Merge fb-mercurial sources into the eden repository 2019-11-13 20:20:32 -08:00
RevisionStore.h Move fb-mercurial sources into an eden/scm subdirectory. 2019-11-13 16:04:48 -08:00